This repository has been archived by the owner on Mar 30, 2023. It is now read-only.
Configure Application Gateway custom probe #206
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit configures a custom probe for Application Gateway. Custom probes now support status codes other than 200-399, so configure the probe to also consider a 401 response as healthy. This removes the need to configure anonymous access to the cluster base path. Closes #201
Application Gateway validation does not allow an empty object for webApplicationFirewallConfiguration; it fails validation with error: ApplicationGatewayFirewallCannotBeEnabledForSelectedSku : Application Gateway /subscriptions/<subscription id>/resourceGroups/<resource group>/providers/Microsoft.Network/applicationGateways/es-app-gateway does not support WebApplicationFirewall with the selected SKU tier Standard
Excluding body appears to not check the :"Use probe matching conditions" box in the portal
Run |
Opened MicrosoftDocs/azure-docs#11805 as custom probe status code matching does not show correctly in the portal, although Application Gateway appears to honour them. |
Mpdreamz
reviewed
Jul 18, 2018
9, | ||
10 | ||
], | ||
"minValue": 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Mpdreamz
reviewed
Jul 18, 2018
@@ -1028,21 +1009,6 @@ configure_elasticsearch_yaml() | |||
echo "xpack.security.enabled: true" >> $ES_CONF | |||
fi | |||
|
|||
# Configure Anonymous access |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ that we can 💥 this now
Mpdreamz
approved these changes
Jul 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR configures a custom probe for Application Gateway.
Custom probes now support status codes other than 200-399, so
configure the probe to also consider a 401 response as healthy.
This removes the need to configure anonymous access to the cluster
base path.
Closes #201