Instead of blacklisting chars in the resource name for cloudformation use whitelisting. #10087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kvch This should solve the issue with the wrong log group, I haven't been able to reproduce the other bug yet. |
kvch
approved these changes
Jan 16, 2019
|
The failing tests are fixed on master. A rebase should correct the errors. |
use whitelisting. Only [a-zA-Z0-9] are permitted as resource name Fixes: elastic#9420
ph
force-pushed
the
fn/correctly-normalize-log-group
branch
from
8857c4d
to
49ab398
Compare
|
rebased and pushed. |
|
errors are not related to this change. |
ph
added
v6.7.0
and removed
needs_backport
ph
added a commit
to ph/beats
that referenced
this pull request
Jan 16, 2019
… use whitelisting. (elastic#10087) * Instead of blacklisting chars in the resource name for cloudformation use whitelisting. Only [a-zA-Z0-9] are permitted as resource name Fixes: elastic#9420 (cherry picked from commit 56c6857)
ph
added a commit
to ph/beats
that referenced
this pull request
Jan 18, 2019
… use whitelisting. (elastic#10087) * Instead of blacklisting chars in the resource name for cloudformation use whitelisting. Only [a-zA-Z0-9] are permitted as resource name Fixes: elastic#9420 (cherry picked from commit 56c6857)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…e resource name for cloudformation use whitelisting. (elastic#10121) Cherry-pick of PR elastic#10087 to 6.6 branch. Original message: Only [a-zA-Z0-9] are permitted as resource name Fixes: elastic#9420
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only [a-zA-Z0-9] are permitted as resource name
Fixes: #9420