Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test checking that all fields are documented #17315

Closed
narph opened this issue Mar 30, 2020 · 1 comment · Fixed by #17334
Closed

Add test checking that all fields are documented #17315

narph opened this issue Mar 30, 2020 · 1 comment · Fixed by #17334
Assignees
Labels
Team:Integrations Label for the Integrations team

Comments

@narph
Copy link
Contributor

narph commented Mar 30, 2020

In the requirements we see the step Automated checks that all fields are documented and this is done automatically in the metricsets that are using an http input and in some cases manually for the other metricsets.
Would be great to reuse

func checkDocumented(t *testing.T, data []common.MapStr, omitFields []string) error {
and add it as a separate test for the other metricsets instead of writing this step manually.

@narph narph self-assigned this Mar 30, 2020
@narph narph added the Team:Integrations Label for the Integrations team label Mar 30, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants