Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat] Autodiscover monitor config collisions #29015

Closed
justinkambic opened this issue Nov 17, 2021 · 2 comments
Closed

[Heartbeat] Autodiscover monitor config collisions #29015

justinkambic opened this issue Nov 17, 2021 · 2 comments
Assignees
Labels
bug Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team

Comments

@justinkambic
Copy link
Contributor

In an attempt to create a fix for the issue described in https://github.com/elastic/sdh-beats/issues/1402 we think we may have found an issue whereby Heartbeat's usage of autodiscover creates multiple configs with the same hash.

Of particular interest is this code, which seems to store the event ID and hash rather than the config hash itself. We are wondering if it makes more sense to attempt to avoid multiple instances of the same config.

There is a community PR for tangential changes; it mentions modifying the way autodiscover works to dedupe config usage.

@justinkambic justinkambic self-assigned this Nov 17, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 17, 2021
@justinkambic justinkambic added the Team:obs-ds-hosted-services Label for the Observability Hosted Services team label Nov 17, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 17, 2021
@justinkambic
Copy link
Contributor Author

Fixed by #29048.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Development

No branches or pull requests

2 participants