Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit how metadata are added for jobs/cronjobs #29771

Closed
ChrsMark opened this issue Jan 10, 2022 · 2 comments · Fixed by #30637
Closed

Revisit how metadata are added for jobs/cronjobs #29771

ChrsMark opened this issue Jan 10, 2022 · 2 comments · Fixed by #30637
Assignees
@ChrsMark
Labels
Team:Integrations Label for the Integrations team

Comments

@ChrsMark
Copy link
Member

ChrsMark commented Jan 10, 2022 •
edited

After we drop support for v1.20 we need to make metadata addition for CronJobs available by default.
Metadata were added at #29572.

Also we need to make sure we handle properly some additional cases at
#29572 (comment)_

Depends on #29604
@ChrsMark ChrsMark added the Team:Integrations Label for the Integrations team label Jan 10, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@ChrsMark ChrsMark mentioned this issue Jan 10, 2022
Merged
@tetianakravchenko
Copy link
Contributor

Additionally: GetKubeStateMetricsConfigWithMetaDisabled can be dropeed https://github.com/elastic/beats/pull/29572/files#diff-1ab984f2f99a7f5241d0b9dd5f77d1d9da3b832456fbddcbcd20122f186fe4bcR33

@ChrsMark ChrsMark mentioned this issue Mar 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChrsMark ChrsMark

Labels
Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add cronjob metadata by default ChrsMark/beats
3 participants
@ChrsMark @elasticmachine @tetianakravchenko