Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing use cases for updated StatsD module tag separation #39681

Closed
ritalwar opened this issue May 23, 2024 · 4 comments
Closed

Testing use cases for updated StatsD module tag separation #39681

ritalwar opened this issue May 23, 2024 · 4 comments
Assignees
Labels
Team:Service-Integrations Label for the Service Integrations team

Comments

@ritalwar
Copy link
Contributor

Although the changes made here seem straightforward and should not impact the existing statsd module functionality.
Can we test use cases for both scenarios (tags separated by ',' and ';') and ensure our current module is working fine?
A routine testing would be beneficial.

@aliabbas-elastic
Copy link
Contributor

Testing Details

Test Setup

  • Used a mock server to send custom format of metrics to StatsD module and verify the results
    • Formats verified:
      • DogStatsD
        <metric name>:<value>|<type>|@samplerate|#<k>:<v>,<k>:<v>
      • InfluxDB
        <metric name>,<k>=<v>,<k>=<v>:<value>|<type>|@samplerate
      • Graphite 1.1.x
        <metric name>;<k>=<v>;<k>=<v>:<value>|<type>|@samplerate

Test Case Scenarios

Test Case Summaries Status
Verify that the metrics in format of DogStatsD are getting parsed Pass 💚
Verify that the metrics in format of InfluxDB are getting parsed Pass 💚
Verify that the metrics in format of Graphite 1.1.x are getting parsed Pass 💚

For now we're good with the above supported formats but more I found here. Should we go on and support them as well?

cc:- @ritalwar @shmsr

@tehbooom
Copy link
Member

@aliabbas-elastic Are we okay to merge or are we wanting to support other formats in this PR as well?

@aliabbas-elastic
Copy link
Contributor

@aliabbas-elastic Are we okay to merge or are we wanting to support other formats in this #39619 as well?

IMO, We should merge the current PR as all the changes are working fine for the specified formats. We can raise for another formats if such enhancement requests come up. But I would like to confirm it with @ritalwar if this is OK to do.

@ritalwar
Copy link
Contributor Author

Thanks @aliabbas-elastic !
Sure, let's merge the PR with the current supported versions, and we can address other formats when the need arises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Development

No branches or pull requests

3 participants