Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heartbeat check custom fields #3623

Closed
mathieuisabel opened this issue Feb 20, 2017 · 6 comments
Closed

Heartbeat check custom fields #3623

mathieuisabel opened this issue Feb 20, 2017 · 6 comments
Assignees

Comments

@mathieuisabel
Copy link

It would be beneficial to support custom fields for individual checks in Heartbeat. For instance, it would be good to be able to have an environment field for the check. Right now we have to stuff this data in the name field which is not convenient for aggregation purposes.

@urso urso self-assigned this Feb 20, 2017
@urso
Copy link

urso commented Mar 13, 2017

TODO: Add support for tags and fields per monitor, as supported by the other beats.

@urso urso mentioned this issue Apr 7, 2017
12 tasks
@glefloch
Copy link
Contributor

@urso, I would be interested into contributing on this issue. Is it possible to mark it as adopt me?

@ruflin
Copy link
Member

ruflin commented Apr 21, 2017

@glefloch no need for the adopt me flag. Just go for it :-D Leave a quick comment here when you start working on it so people know that it's in progress.

@glefloch
Copy link
Contributor

ok, then, I start working on it. :)

@urso
Copy link

urso commented Apr 21, 2017

Any contribution is very welcome ;)

I'd say you want to have a look at the annotated function in util.go.

Note, we're doing some event format update according to #3406 also touching the same function. Just to give you a warning that some merge conflict might come up (easily resolvable via rebase). We can help in PR if this happens.

@glefloch
Copy link
Contributor

Great, thank you.

I will be careful when pushing my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants