Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor association controllers #2698

Closed
sebgl opened this issue Mar 13, 2020 · 0 comments · Fixed by #2786
Closed

Refactor association controllers #2698

sebgl opened this issue Mar 13, 2020 · 0 comments · Fixed by #2786
Assignees

Comments

@sebgl
Copy link
Contributor

sebgl commented Mar 13, 2020

Kibana, APMServer and EnterpriseSearch have a very similar association logic with Elasticsearch.
There respective association controller code is pretty similar, but also diverges a little bit, which makes maintenance complicated in the long-term.

We could create a common esassociation package holding the logic to associate a generic resource to Elasticsearch.
Each individual association controller would still exist, but would rely a lot on the common esassociation library.

It also simplifies unit testing: most of the testing is done in a single place (the common package). Unit tests for individual controllers can be much simpler and focus on high-level testing and specific parts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant