Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport certs public secret name is not expected #3034

Closed
sebgl opened this issue May 11, 2020 · 1 comment · Fixed by #3035
Closed

Transport certs public secret name is not expected #3034

sebgl opened this issue May 11, 2020 · 1 comment · Fixed by #3035
Labels
>bug Something isn't working

Comments

@sebgl
Copy link
Contributor

sebgl commented May 11, 2020

Looks like I accidentally changed the name of the transport certs public certificates in 608642b.

It is now (as of 1.1.0) named <cluster>-es-ca-certs-public whereas it used to be <cluster-name>-es-transport-certs-public before this commit (in 1.0.0).

The docs for 1.1.0 mention the (now incorrect) <cluster>-es-transport-certs-public naming scheme.

I see 2 options here:

  1. We change it back to <cluster-name>-es-transport-certs-public in a 1.1.1 version.
  2. We change the docs to use <cluster>-es-ca-certs-public starting 1.1.0.

Considering we also have <cluster-name>-es-http-certs-public, I think the first option makes more sense.

@sebgl sebgl added the >bug Something isn't working label May 11, 2020
@barkbay
Copy link
Contributor

barkbay commented May 11, 2020

I think I would be in favour of a rename to <cluster-name>-es-transport-certs-public
I don't think it is widely used yet and it would make more sense re. http certs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants