Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statefulset metadata Annotations removed by operator #3147

Closed
oliveagle opened this issue May 27, 2020 · 1 comment · Fixed by #3149
Closed

Statefulset metadata Annotations removed by operator #3147

oliveagle opened this issue May 27, 2020 · 1 comment · Fixed by #3149
Assignees
Labels
>bug Something isn't working

Comments

@oliveagle
Copy link

Bug Report

What did you do?

Create a ElasticSearch cluster with 3 nodes. add some annotations in sts metadata. then scale up the cluster. Annotation we added in sts metadata disappered.

Add arbitrary annotations in sts metadata

image

Do these following operations. they all will remove annotations in sts metadata

  • scale up/down
  • replace image version of ElasticSearch

What did you expect to see?

We need those annotations to be persistent.(operator don't clean customized annotations in sts metadata).

Environment

  • ECK version:

    version: 1.1.1
    hash: b6f69fc

We added 3 line of code that solve this problem. Here are the changes.

image

@botelastic botelastic bot added the triage label May 27, 2020
@sebgl sebgl added the >bug Something isn't working label May 27, 2020
@botelastic botelastic bot removed the triage label May 27, 2020
@sebgl
Copy link
Contributor

sebgl commented May 27, 2020

Related: #2652 to include the sset annotations in the Elasticsearch resource

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants