Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit node shutdown clean up and improve testing #5632

Closed
pebrc opened this issue Apr 29, 2022 · 0 comments · Fixed by #5642
Closed

Revisit node shutdown clean up and improve testing #5632

pebrc opened this issue Apr 29, 2022 · 0 comments · Fixed by #5642
Assignees
Labels
>refactoring >test Related to unit/integration/e2e tests

Comments

@pebrc
Copy link
Collaborator

pebrc commented Apr 29, 2022

#5629 implemented a minimal fix to address the issue with auto_expand_replicas and node shutdown.

We should look into improving the testing around that e.g through a continuous check during mutation tests that ensure that at most as many shutdowns exist as the change budget allows.

We could also improve the code a bit and for example move all clean up to the top of the upgrade function.

@pebrc pebrc added >test Related to unit/integration/e2e tests >refactoring labels Apr 29, 2022
@pebrc pebrc self-assigned this May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>refactoring >test Related to unit/integration/e2e tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant