Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Air-gapped documentation describes how to use a mirrored operator image #7019

Merged
merged 9 commits into from Jul 20, 2023

Conversation

jeanfabrice
Copy link
Contributor

Add a chapter how to run the ECK operator itself in an air-gapped environment

Add a chapter how to run the ECK operator itself in an air-gapped environment
@botelastic botelastic bot added the triage label Jul 13, 2023
@thbkrkr thbkrkr added the >docs Documentation label Jul 13, 2023
@botelastic botelastic bot removed the triage label Jul 13, 2023
@kunisen
Copy link
Contributor

kunisen commented Jul 14, 2023

Thanks @jeanfabrice for raising the doc PR!! 🙇
I built the docs and found {eck_version} is not reflected as the real version, as other sections in ECK docs.
Maybe you need to tweak the asciidoc and copy from other places to see if it can show the correct version.


image
# you can clone elastic/docs repository and run this command to build the ECK docs and show it in browser
# https://github.com/elastic/docs/blob/master/doc_build_aliases.sh
> docbldeck --open

@jeanfabrice
Copy link
Contributor Author

Let me check. I naively thought this variable would be available cross doc page. Maybe the current doc page is missing some bits of configuration. Thanks!

@cla-checker-service
Copy link

cla-checker-service bot commented Jul 15, 2023

💚 CLA has been signed

@jeanfabrice
Copy link
Contributor Author

@kunisen According to https://docs.asciidoctor.org/asciidoc/latest/text/monospace/, asciidoc attributes, like {eck_version}, should resolve properly when used inside monospace code.
It doesn't work with our doc builder, and I don't know why. Note that the simple documentation example, E=mc^2^, doesn't work either.
I'm asking the doc team.

@jeanfabrice
Copy link
Contributor Author

@kunisen the issue with the attribute resolution is now fixed

@kunisen
Copy link
Contributor

kunisen commented Jul 18, 2023

Thank you Jean-Fabrice so much for the amazing effort!

Copy link
Collaborator

@pebrc pebrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks for raising this.

docs/operating-eck/air-gapped.asciidoc Outdated Show resolved Hide resolved
docs/operating-eck/air-gapped.asciidoc Outdated Show resolved Hide resolved
jeanfabrice and others added 3 commits July 19, 2023 08:43
Co-authored-by: Peter Brachwitz <peter.brachwitz@elastic.co>
@thbkrkr thbkrkr changed the title Update air-gapped.asciidoc Add to air-gapped doc how to use a mirrored operator image Jul 19, 2023
@thbkrkr thbkrkr merged commit 2999dd3 into main Jul 20, 2023
5 checks passed
thbkrkr added a commit to thbkrkr/cloud-on-k8s that referenced this pull request Jul 20, 2023
)

Add a chapter how to run the ECK operator itself in an air-gapped environment.

---------

Co-authored-by: Peter Brachwitz <peter.brachwitz@elastic.co>
Co-authored-by: Thibault Richard <thb.krkr@gmail.com>
thbkrkr added a commit that referenced this pull request Jul 20, 2023
…7048)

Add a chapter how to run the ECK operator itself in an air-gapped environment.

---------

Co-authored-by: Jean-Fabrice Bobo <2949987+jeanfabrice@users.noreply.github.com>
Co-authored-by: Peter Brachwitz <peter.brachwitz@elastic.co>
@thbkrkr thbkrkr deleted the jeanfabrice-docfix-1 branch August 31, 2023 20:43
@rhr323 rhr323 changed the title Add to air-gapped doc how to use a mirrored operator image Air-gapped documentation describes how to use a mirrored operator image Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants