Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sed command to use FIPS compatible operator image in FIPS doc #7076

Merged
merged 1 commit into from Aug 4, 2023

Conversation

thbkrkr
Copy link
Contributor

@thbkrkr thbkrkr commented Aug 4, 2023

This corrects the sed command used to change the container image name to use the FIPS-enabled version in the k8s manifests to deploy the operator.

Reported in 3043fbf by @emrcbrn.

Previous command was renaming the image to:

curl -s https://download.elastic.co/downloads/eck/2.6.1/operator.yaml | sed -r 's#(image:.*eck-operator.*)"#\1-fips"#' | grep fips
image: "docker.elastic.co/eck/eck-operator:2.6.1-fips"

Which isn't found:

docker pull docker.elastic.co/eck/eck-operator:2.6.1-fips
Error response from daemon: manifest for docker.elastic.co/eck/eck-operator:2.6.1-fips not found: manifest unknown: manifest unknown

The new sed command renames it correctly:

curl -s https://download.elastic.co/downloads/eck/2.6.1/operator.yaml | sed -r 's#(image:.*eck-operator)(:.*)#\1-fips\2#' | grep fips
image: "docker.elastic.co/eck/eck-operator-fips:2.6.1"

Which pulls correctly:

docker pull docker.elastic.co/eck/eck-operator-fips:2.6.1
2.6.1: Pulling from eck/eck-operator-fips
fc251a6e7981: Pull complete 
029c2b2b0b4e: Pull complete 
67be15e29e15: Pull complete 
cf5b1a76c1a2: Pull complete 
Digest: sha256:49ba2ed24db1bbb4806709226ec23262bf6adc8db63d6f87751869a4839efc1d
Status: Downloaded newer image for docker.elastic.co/eck/eck-operator-fips:2.6.1
docker.elastic.co/eck/eck-operator-fips:2.6.1

Correct the sed command as the previous one changed the name to an invalid image
@thbkrkr thbkrkr added >docs Documentation v2.10.0 labels Aug 4, 2023
@thbkrkr thbkrkr changed the title Update fips.asciidoc Fix sed command to use FIPS compatible operator image in FIPS doc Aug 4, 2023
@thbkrkr thbkrkr merged commit 20b24e7 into elastic:main Aug 4, 2023
5 checks passed
@thbkrkr thbkrkr deleted the fix-fips-doc branch November 9, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs Documentation v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants