Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating scripts configMap no longer causes Elasticsearch restart #7114

Merged
merged 2 commits into from Aug 26, 2023
Merged

Updating scripts configMap no longer causes Elasticsearch restart #7114

merged 2 commits into from Aug 26, 2023

Conversation

cr7258
Copy link
Contributor

@cr7258 cr7258 commented Aug 23, 2023

Use contents of the script Configmap to generate config hash to avoid unnecessary cluster restart, fix: #6963

@cla-checker-service
Copy link

cla-checker-service bot commented Aug 23, 2023 •
edited

💚 CLA has been signed

@botelastic botelastic bot added the triage label Aug 23, 2023
@cr7258 cr7258 force-pushed the config-hash branch 2 times, most recently from 449c16a to 0f030a0 Compare August 24, 2023 01:42
@pebrc
Copy link
Collaborator

pebrc commented Aug 25, 2023

buildkite test this -f p=gke,t=TestESSuspendPod

@pebrc pebrc added >bug Something isn't working v2.10.0 labels Aug 25, 2023
@botelastic botelastic bot removed the triage label Aug 25, 2023
pebrc
pebrc reviewed Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@pebrc pebrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! You change looks good and I think we can merge soon. Could you add a unit test for the getScriptsConfigMapContent function?

pkg/controller/elasticsearch/nodespec/podspec.go Show resolved Hide resolved
@pebrc
Copy link
Collaborator

pebrc commented Aug 25, 2023

@elasticmachine , run elasticsearch-ci/docs

@cr7258 cr7258 requested a review from pebrc August 25, 2023 14:24
@pebrc
Copy link
Collaborator

pebrc commented Aug 26, 2023

@elasticmachine , run elasticsearch-ci/docs

@pebrc
Copy link
Collaborator

pebrc commented Aug 26, 2023

buildkite test this

@pebrc pebrc enabled auto-merge (squash) August 26, 2023 08:02
@pebrc pebrc merged commit 6196b31 into elastic:main Aug 26, 2023
5 checks passed
@rhr323 rhr323 changed the title Use contents of the script Configmap to generate config hash Updating scripts configMap no longer causes Elasticsearch restart Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pebrc pebrc pebrc approved these changes

Assignees
No one assigned
Labels
>bug Something isn't working v2.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating or deleting scripts configMap may cause ES to restart
2 participants
@cr7258 @pebrc