eck-beats/templates/beats.yaml adds spec.type: foo twice

[ke5C2Fin]

Bug Report

What did you do?

First I tried installing the chart, then used helm template to debug it.

helm template elastic/eck-beats -f values.yaml

What did you expect to see?
I expected the chart to install successfully.

What did you see instead? Under which circumstances?
Without .Values.spec.type defined

Error: execution error at (eck-beats/templates/beats.yaml:15:11): A Beat type is required

With .Values.spec.type defined

Helm install failed for release elastic-stack/elastic-stack-beats-infra with chart eck-beats@0.9.0: error while running post render on files: map[string]interface {}(nil): yaml: unmarshal errors: line 46: mapping key "type" already defined at line 17

spec:
  version: {{ required "A Beat version is required" .Values.version }}
  type: {{ required "A Beat type is required" .Values.spec.type }}
  {{- if and (not (hasKey .Values.spec "daemonSet")) (not (hasKey .Values.spec "deployment")) }}
  {{ fail "At least one of daemonSet or deployment is required for a functional Beat" }}
  {{- end }}
  {{- toYaml .Values.spec | nindent 2 }}

The template explicitly adds .spec.type from .Values.spec.type and then adds .Values.spec which includes .Values.spec.type again, resulting in a Beats CRD with .spec.type twice.

Environment

• ECK version: 2.9, 2.10, 2.11

[thbkrkr]

Thanks for the report, there is indeed a bug in the Beats Helm chart that causes the type field to be duplicated.

> helm template elastic/eck-beats -f examples/filebeat_no_autodiscover.yaml | grep 'type: filebeat'
  type: filebeat
  type: filebeat