Update openapi files for ECE 3.7.0 and regenerate swagger code #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gersonsosa
reviewed
Apr 8, 2024
|
Actually some unit tests are failing, looks like the |
beiske
force-pushed
the
update-swagger
branch
3 times, most recently
from
cccc156
to
fa8e172
Compare
beiske
commented
Apr 9, 2024
| @@ -136,7 +136,7 @@ func TestCloudClientRuntime_getRuntime(t *testing.T) { | |||
| args: args{op: &runtime.ClientOperation{ | |||
| PathPattern: "/deployments", | |||
| }}, | |||
| want: &runtimeclient.Runtime{BasePath: "/api/v1/"}, | |||
| want: &runtimeclient.Runtime{BasePath: "/api/v1"}, | |||
There was a problem hiding this comment.
I assumed this was benign, but not sure why it changed
There was a problem hiding this comment.
Basepath was updated in openapi spec file, because some language generators not generating correct URL's if there was a trailing slash.
|
Just signing the last commit doesn't appear to be good enough so I squashed all commits and signed again |
Delete noteapi Trying to fix some tests... Signed-off-by: Konrad Beiske <konrad@beiske.org>
beiske
added a commit
to beiske/cloud-sdk-go
that referenced
this pull request
Apr 10, 2024
beiske
added a commit
that referenced
this pull request
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update openapi spec in preparation for ECE 3.7.0 and regenerate swagger code
Related Issues
Motivation and Context
How Has This Been Tested?
Types of Changes
Readiness Checklist