Deploymentapi: Add missing GET parameters. #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
dimuon
reviewed
May 14, 2024
| WithShowSettings(ec.Bool(params.ShowSettings)). | ||
| WithConvertLegacyPlans(ec.Bool(params.ConvertLegacyPlans)). | ||
| WithShowSystemAlerts(systemAlerts) | ||
| if params.ShowInstanceConfigurations { |
There was a problem hiding this comment.
Why can't we use the same style as for, e.g. ShowPlans? E.g.
.WithShowInstanceConfigurations(ec.Bool(params.ShowInstanceConfigurations))
instead of the explicit if?
There was a problem hiding this comment.
The difference is that the if only adds the parameter to the request if it is set to true (assuming the default in the API is false as well). The other parameters will be added to every request.
My reasoning behind it is that it will only add the parameter to the request when it is needed. So if you don't use the new params, nothing will change in the request being made.
Another option would be to make the parameters *bool and pass them straight in. Then it is still possible in the cloud-sdk-go api to decide to either set the parameter, or not set it and it will not be added.
dimuon
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements some new fields in the deployment.get API that weren't supported yet by the SDK.
Description
Related Issues
Motivation and Context
How Has This Been Tested?
Types of Changes
Readiness Checklist