CI improvements (#2080)

* Move opa ci to new ci workflow

* change retention of logs to 1 day

* revert opa to extract to separate pr

.github/actions/aws-ci/action.yml

@@ -51,15 +51,19 @@ runs:
       run: poetry run pytest -k "aws" --alluredir=./allure/results/ --clean-alluredir
 
     - name: Upload test results
-      if: ${{ success() || failure() }}
+      if: ${{ always() }}
       uses: actions/upload-artifact@v4
       with:
         name: allure-results-ci-aws
         path: tests/allure/results/
+        overwrite: true
 
-    - if: ${{ (success() || failure()) && inputs.debug == 'true' }}
+    - if: ${{ failure() || cancelled() || inputs.debug == 'true' }}
       name: Upload cloudbeat logs
       uses: actions/upload-artifact@v4
       with:
         name: cloubeat-logs-ci-aws
         path: logs/
+        if-no-files-found: warn
+        retention-days: 1
+        overwrite: true

.github/actions/azure-ci/action.yml

@@ -52,15 +52,19 @@ runs:
       run: poetry run pytest -k "azure" --alluredir=./allure/results/ --clean-alluredir
 
     - name: Upload test results
-      if: ${{ success() || failure() }}
+      if: ${{ always() }}
       uses: actions/upload-artifact@v4
       with:
         name: allure-results-ci-azure
         path: tests/allure/results/
+        overwrite: true
 
-    - if: ${{ (success() || failure()) && inputs.debug == 'true' }}
+    - if: ${{ failure() || cancelled() || inputs.debug == 'true' }}
       name: Upload cloudbeat logs
       uses: actions/upload-artifact@v4
       with:
         name: cloubeat-logs-ci-azure
         path: logs/
+        if-no-files-found: warn
+        retention-days: 1
+        overwrite: true

.github/actions/cnvm-ci/action.yml

@@ -54,15 +54,19 @@ runs:
         poetry run pytest -k "cnvm" --alluredir=./allure/results/ --clean-alluredir
 
     - name: Upload test results
-      if: ${{ success() || failure() }}
+      if: ${{ always() }}
       uses: actions/upload-artifact@v4
       with:
         name: allure-results-ci-cnvm
         path: tests/allure/results/
+        overwrite: true
 
-    - if: ${{ (success() || failure()) && inputs.debug == 'true' }}
+    - if: ${{ failure() || cancelled() || inputs.debug == 'true' }}
       name: Upload cloudbeat logs
       uses: actions/upload-artifact@v4
       with:
         name: cloubeat-logs-ci-cnvm
         path: logs/
+        if-no-files-found: warn
+        retention-days: 1
+        overwrite: true

.github/actions/docker-images/action.yml

@@ -127,6 +127,9 @@ runs:
       with:
         name: docker-images
         path: ${{ inputs.docker-images-folder }}
+        if-no-files-found: error
+        retention-days: 2
+        overwrite: true
 
     - if: ${{ inputs.build-docker-images == 'false' }}
       name: Download docker images

.github/actions/gcp-ci/action.yml

@@ -56,15 +56,19 @@ runs:
         poetry run pytest -k "cspm_gcp" --alluredir=./allure/results/ --clean-alluredir --maxfail=4
 
     - name: Upload test results
-      if: ${{ success() || failure() }}
+      if: ${{ always() }}
       uses: actions/upload-artifact@v4
       with:
         name: allure-results-ci-gcp
         path: tests/allure/results/
+        overwrite: true
 
-    - if: ${{ (success() || failure()) && inputs.debug == 'true' }}
+    - if: ${{ failure() || cancelled() || inputs.debug == 'true' }}
       name: Upload cloudbeat logs
       uses: actions/upload-artifact@v4
       with:
         name: cloubeat-logs-ci-gcp
         path: logs/
+        if-no-files-found: warn
+        retention-days: 1
+        overwrite: true

.github/actions/k8s-ci/action.yml

@@ -60,8 +60,9 @@ runs:
       run: just run-tests ${{ inputs.test-target }} kind-${{ inputs.kind-config }}
 
     - name: Upload Test Results
-      if: ${{ success() || failure() }}
+      if: ${{ always() }}
       uses: actions/upload-artifact@v4
       with:
         name: allure-results-ci-k8s-${{ inputs.test-target }}-${{ inputs.kind-config }}
         path: tests/allure/results/
+        overwrite: true

.github/workflows/ci.yml

@@ -105,6 +105,7 @@ jobs:
         with:
           name: coverage-file
           path: cover.out
+          overwrite: true
 
       - name: Send coverage
         env:
@@ -188,7 +189,7 @@ jobs:
     needs: [ init-hermit ]
     name: CNVM CI
     runs-on: ubuntu-22.04
-    timeout-minutes: 30
+    timeout-minutes: 15
     steps:
       - name: Check out the repo
         uses: actions/checkout@v4
@@ -306,7 +307,7 @@ jobs:
     timeout-minutes: 60
     permissions:
       pull-requests: write
-    if: ${{ success() || failure() }}
+    if: ${{ always() }}
     env:
       AWS_REGION: "eu-west-1"
       ALLURE_S3_BUCKET: "s3://csp-allure-reports/allure_reports/cloudbeat/ci"
@@ -316,20 +317,20 @@ jobs:
         uses: actions/checkout@v4
 
       - uses: actions/download-artifact@v4
-        if: ${{ success() || failure() }}
+        if: ${{ always() }}
         with:
           pattern: allure-results-ci-*
           path: tests/allure/results/
           merge-multiple: true
 
       - name: log
-        if: ${{ success() || failure() }}
+        if: ${{ always() }}
         shell: bash
         run: |
           ls -lahR tests/allure/results/ || true
 
       - name: Publish allure report
-        if: ${{ success() || failure() }}
+        if: ${{ always() }}
         uses: andrcuns/allure-publish-action@v2.6.0
         env:
           GITHUB_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -377,7 +378,7 @@ jobs:
           message: |
             ${{ env.ALLURE_SUMMARY }}
 
-      - if: ${{ always() }}
+      - if: ${{ success() }}
         name: Cleanup docker image artifacts
         uses: geekyeggo/delete-artifact@v5
         with: