Skip to content

Commit

Permalink
Merge branch 'main' into revert-2088-label_gcp_deployments
Browse files Browse the repository at this point in the history
  • Loading branch information
uri-weisman committed Apr 11, 2024
2 parents c9e5308 + 73f2940 commit c4a1e74
Show file tree
Hide file tree
Showing 30 changed files with 44 additions and 36 deletions.
20 changes: 10 additions & 10 deletions .github/actions/slack-notification/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,13 +82,13 @@ jobs:

Following inputs can be used as `step.with` keys:

| Name | Type | Required | Description |
|------------------|----------|----------|-------------------------------------------------------------|
| `vault-role-id` | String | yes | The Vault role id. |
| `vault-secret-id`| String | yes | The Vault secret id. |
| `vault-url` | String | yes | The Vault URL to connect to. |
| `slack-channel` | String | no | Slack channel id or channel name. Default: #csp-qa-alerts |
| `slack-message` | String | no | Posting a simple plain text message. |
| `slack-payload` | String | no | Posting a rich message using Block Kit. |
| `mask-secrets` | String | no | Masking secrets in the logs. Default: 'true' |
| `url-encoded` | String | no | URL-encoded message. Default: 'true' |
| Name | Type | Required | Description |
|------------------|----------|----------|-------------------------------------------------------------------|
| `vault-role-id` | String | yes | The Vault role id. |
| `vault-secret-id`| String | yes | The Vault secret id. |
| `vault-url` | String | yes | The Vault URL to connect to. |
| `slack-channel` | String | no | Slack channel id or channel name. Default: #cloud-sec-qa-alerts |
| `slack-message` | String | no | Posting a simple plain text message. |
| `slack-payload` | String | no | Posting a rich message using Block Kit. |
| `mask-secrets` | String | no | Masking secrets in the logs. Default: 'true' |
| `url-encoded` | String | no | URL-encoded message. Default: 'true' |
2 changes: 1 addition & 1 deletion .github/actions/slack-notification/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ inputs:
slack-channel:
description: 'Slack channel'
required: false
default: '#csp-qa-alerts'
default: '#cloud-sec-qa-alerts'
slack-message:
description: 'Slack message: For multiple lines, provide a URL-encoded message and set url-encoded to true'
required: false
Expand Down
20 changes: 14 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ jobs:
init-tools: 'true'

lint:
needs: [ init-hermit ]
name: Lint
runs-on: ubuntu-22.04
timeout-minutes: 60
Expand All @@ -42,8 +41,16 @@ jobs:
# If the event is push to branch use the default ref.
# If the event is pull request (`pull_request_target` in our case) use merge commit as ref to run lint over the PR's code.

- name: Hermit Environment
uses: ./.github/actions/hermit
- name: Initialize hermit
shell: bash
run: |
./bin/hermit env --raw >> "$GITHUB_ENV"
- name: Initialize poetry
shell: bash
run: |
pip3 install poetry
(cd security-policies && poetry install --no-root)
- name: Pre-commit Hooks
env:
Expand Down Expand Up @@ -74,7 +81,6 @@ jobs:
run: terraform fmt -check -recursive

unit-test:
needs: [ init-hermit ]
name: Unit Test
runs-on: ubuntu-22.04
timeout-minutes: 60
Expand All @@ -86,8 +92,10 @@ jobs:
# If the event is push to branch use the default ref.
# If the event is pull request (`pull_request_target` in our case) use merge commit as ref to run unit tests over the PR's code.

- name: Hermit Environment
uses: ./.github/actions/hermit
- name: Initialize hermit
shell: bash
run: |
./bin/hermit env --raw >> "$GITHUB_ENV"
- name: Build opa bundle
shell: bash
Expand Down
8 changes: 4 additions & 4 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ repos:

## Golang hooks
- repo: https://github.com/golangci/golangci-lint
rev: v1.56.1
rev: v1.57.2
hooks:
- id: golangci-lint

Expand All @@ -39,7 +39,7 @@ repos:
files: ^(.ci/scripts|.github/actions|tests)/

- repo: https://github.com/pycqa/pylint
rev: v3.0.3
rev: v3.1.0
hooks:
- id: pylint
args: [
Expand All @@ -50,7 +50,7 @@ repos:
exclude: security-policies.*

- repo: https://github.com/psf/black
rev: 24.1.1
rev: 24.3.0
hooks:
- id: black

Expand All @@ -67,7 +67,7 @@ repos:
files: deploy/cloudformation/.*yml

- repo: https://github.com/awslabs/cfn-python-lint
rev: v0.85.0
rev: v0.86.2
hooks:
- id: cfn-python-lint
files: deploy/cloudformation/.*.yml
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion bin/bq
2 changes: 1 addition & 1 deletion bin/docker-credential-gcloud
2 changes: 1 addition & 1 deletion bin/elastic-package
2 changes: 1 addition & 1 deletion bin/gcloud
2 changes: 1 addition & 1 deletion bin/gh
2 changes: 1 addition & 1 deletion bin/git-credential-gcloud.sh
2 changes: 1 addition & 1 deletion bin/golangci-lint
2 changes: 1 addition & 1 deletion bin/gsutil
2 changes: 1 addition & 1 deletion bin/just
2 changes: 1 addition & 1 deletion bin/kind
2 changes: 1 addition & 1 deletion bin/opa
2 changes: 1 addition & 1 deletion bin/pre-commit
2 changes: 1 addition & 1 deletion bin/shellcheck
2 changes: 1 addition & 1 deletion bin/shfmt
2 changes: 1 addition & 1 deletion bin/yq

0 comments on commit c4a1e74

Please sign in to comment.