Adding capability of running automated process rules tests #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudbeat CI 🤖Integration tests passed! 💚 =========================== short test summary info ============================
PASSED integration/tests/test_output_to_elasticsearch.py::test_elastic_index_exists[file]
PASSED integration/tests/test_output_to_elasticsearch.py::test_elastic_index_exists[process]
PASSED integration/tests/test_output_to_elasticsearch.py::test_elastic_index_exists[k8s_object]
PASSED product/tests/test_cloudbeat.py::test_cloudbeat_pod_exist
PASSED product/tests/test_cloudbeat.py::test_cloudbeat_pods_running
================= 5 passed, 60 deselected, 6 warnings in 1.26s =================Link to detailed report: https://elastic.github.io/cloudbeat/579 |
gurevichdmitry
requested changes
May 12, 2022
tests/commonlib/io_utils.py
Outdated
|
|
||
| # Wait for process reboot | ||
| # TODO: Implement a more optimal way of waiting | ||
| time.sleep(60) |
There was a problem hiding this comment.
Not a good idea to put sleep function on infra level.
tests/product/tests/test_rules.py
Outdated
| # ), | ||
| ], | ||
| ) | ||
| def test_process_rules(data, |
There was a problem hiding this comment.
It is possible to create a separate file for process rule tests.
jeniawhite
force-pushed
the
evgb-ProcessTestsInitial
branch
from
852fdcc
to
92bab7d
Compare
jeniawhite
force-pushed
the
evgb-ProcessTestsInitial
branch
from
807db3c
to
e17a451
Compare
jeniawhite
force-pushed
the
evgb-ProcessTestsInitial
branch
from
259e8ed
to
1408db6
Compare
uri-weisman
requested changes
May 26, 2022
| raise Exception( | ||
| f"Command '{command}' still not implemented in test framework") | ||
|
|
||
| @staticmethod |
There was a problem hiding this comment.
Can we plz add some description to the function?
jeniawhite
force-pushed
the
evgb-ProcessTestsInitial
branch
from
d112a55
to
d09a84f
Compare
uri-weisman
approved these changes
May 26, 2022
orouz
pushed a commit
to orouz/cloudbeat
that referenced
this pull request
Sep 6, 2023
* Initial commit of kubelet audits and refactoring to process * Code review changes * Refactor "with" keyword in tests * Fixing duplicated "with" parameters
orestisfl
pushed a commit
to orestisfl/cloudbeat
that referenced
this pull request
Oct 11, 2023
…ctor (elastic#127) * Initial commit of kubelet audits and refactoring to process * Code review changes * Refactor "with" keyword in tests * Fixing duplicated "with" parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancing the tests framework to automatically evaluate process rules
Fixes #157