Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GA Workflows to Actions #2000

Merged
merged 29 commits into from
Mar 27, 2024
Merged

GA Workflows to Actions #2000

merged 29 commits into from
Mar 27, 2024

Conversation

moukoublen
Copy link
Member

@moukoublen moukoublen commented Mar 5, 2024

Summary of your changes

Screenshot/Data

Untitled drawing (1)

Related Issues

Fixes: #1976

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

Introducing a new rule?

@mergify mergify bot added the backport-skip label Mar 5, 2024
@mergify mergify bot mentioned this pull request Mar 5, 2024
5 tasks
@moukoublen moukoublen force-pushed the refactor_ga_workflows branch 13 times, most recently from d4570a8 to d1e0c8d Compare March 12, 2024 09:40
@moukoublen moukoublen force-pushed the refactor_ga_workflows branch 2 times, most recently from 6221555 to 813ca5d Compare March 14, 2024 09:34
@moukoublen moukoublen mentioned this pull request Mar 14, 2024
5 tasks
@moukoublen moukoublen force-pushed the refactor_ga_workflows branch 11 times, most recently from fb932ed to 9132566 Compare March 19, 2024 09:56
@moukoublen
Copy link
Member Author

@gurevichdmitry Yes eks could be added as well and separated it by if: ${{ github.event_name != 'pull_request' }} to run only after merge.

But it might be better to add it as a separate task to keep the scope of this PR as is if its ok by you also.

@gurevichdmitry
Copy link
Collaborator

@gurevichdmitry Yes eks could be added as well and separated it by if: ${{ github.event_name != 'pull_request' }} to run only after merge.

But it might be better to add it as a separate task to keep the scope of this PR as is if its ok by you also.

@moukoublen, I agree. It would be better to handle the EKS flow as a separate task. Could you please open one for that?

Copy link
Collaborator

@gurevichdmitry gurevichdmitry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moukoublen LGTM! Please also create a task for deprecating workflows that are currently conditioned with if: ${{ false }}.

@moukoublen moukoublen enabled auto-merge (squash) March 27, 2024 09:59
@moukoublen moukoublen merged commit 91a8049 into main Mar 27, 2024
4 checks passed
@moukoublen moukoublen deleted the refactor_ga_workflows branch March 27, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor and centralize cloudbeat testing workflows
4 participants