fix ci results comment

[moukoublen]

Summary of your changes

Fix the missing comment in PRs with allure report.

Screenshot/Data

Related Issues

Checklist

• I have added tests that prove my fix is effective or that my feature works
• I have added the necessary README/documentation (if appropriate)

Introducing a new rule?

• Generate rule metadata using this script
• Add relevant unit tests
• Generate relevant rule templates using this script, and open a PR in elastic/packages/cloud_security_posture

[mergify]

This pull request does not have a backport label. Could you fix it @moukoublen? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
  NOTE: backport-skip has been added to this pull request.

[github-actions]

❌ No tests were run ❌

[github-actions]

📊 Allure Report - 💚 No failures were reported.

Result	Count
🟥 Failed	0
🟩 Passed	359
⬜ Skipped	33

[gurevichdmitry]

@moukoublen, to prevent script injection, it's better to store github.event_name as an environment variable.

shell: bash
env:
    EVENT_NAME: ${{ github.event_name }}
run: |
    ls -lahR tests/allure/results/ || true
    echo "event_name: ${EVENT_NAME}"

[moukoublen]

I forgot to delete that entirely; I just put it there for debugging reasons while trying things. I will delete it.

(Also I think in this specific case, the event_name is predefined by github and not related to user input)

[gurevichdmitry]

Why do we need this permission?

[moukoublen]

To be honest, I am not sure if we actually need it. We shouldn't.

The issue is that summary entries and comments do not appear in forks-originated PRs; they do appear in PRs from this repo.

So my initial assumption is that:

• Either github.event_name in case of pull_request_target is not 'pull_request' (so I changed the if to if: ${{ success() && github.event_name != 'push' }})
• Or this permission is needed (because it is also present in this workflow

  cloudbeat/.github/workflows/publish-test-results.yml

  Line 24 in 2451b25

  checks: write

  )

Do you think we should first merge the first only, and if it does not work, then we should try the check: write permission?

[gurevichdmitry]

Let's attempt to merge without it (checks: write), and if necessary, we can add this permission later.