-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump github.com/moby/buildkit from 0.11.6 to 0.12.5 #2076
Conversation
This pull request does not have a backport label. Could you fix it @moukoublen? 🙏
|
0070469
to
0a24f5b
Compare
📊 Allure Report - 💚 No failures were reported.
|
0a24f5b
to
9b545c7
Compare
9b7cc90
to
f59be1a
Compare
go.opentelemetry.io/otel/metric v0.38.0 => go.opentelemetry.io/otel/metric v0.34.0 | ||
oras.land/oras-go => oras.land/oras-go v1.2.4-0.20230801060855-932dd06d38af |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason why these don't need to be replaced anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we specifically need oras.land/oras-go@v1.2.5
buildkit 0.12.5 needs docker v25
https://github.com/moby/buildkit/blob/v0.12.5/go.mod#L31
But oras-go 1.2.4 breaks with newer docker so we need 1.2.5
(check Important
in the release notes)
https://github.com/oras-project/oras-go/releases/tag/v1.2.5
the other one go.opentelemetry.io/otel/metric v0.38.0 => go.opentelemetry.io/otel/metric v0.34.0
is not useful anymore since we have metric v1.24.0
so the replace does nothing to sum.
Summary of your changes
Screenshot/Data
Related Issues
Checklist
Introducing a new rule?