Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/moby/buildkit from 0.11.6 to 0.12.5 #2076

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

moukoublen
Copy link
Member

Summary of your changes

Screenshot/Data

Related Issues

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

Introducing a new rule?

@moukoublen moukoublen requested a review from a team as a code owner April 1, 2024 08:53
Copy link

mergify bot commented Apr 1, 2024

This pull request does not have a backport label. Could you fix it @moukoublen? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip label Apr 1, 2024
@moukoublen moukoublen changed the title Bump github.com/moby/buildkit from 0.11.6 to 0.12.5 Bump github.com/moby/buildkit from 0.11.6 to 0.13.1 Apr 1, 2024
Copy link

github-actions bot commented Apr 1, 2024

📊 Allure Report - 💚 No failures were reported.

Result Count
🟥 Failed 0
🟩 Passed 359
⬜ Skipped 33

@moukoublen moukoublen changed the title Bump github.com/moby/buildkit from 0.11.6 to 0.13.1 Bump github.com/moby/buildkit from 0.11.6 to 0.12.5 Apr 1, 2024
@elastic elastic deleted a comment from github-actions bot Apr 1, 2024
Comment on lines -530 to -531
go.opentelemetry.io/otel/metric v0.38.0 => go.opentelemetry.io/otel/metric v0.34.0
oras.land/oras-go => oras.land/oras-go v1.2.4-0.20230801060855-932dd06d38af
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason why these don't need to be replaced anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we specifically need oras.land/oras-go@v1.2.5

buildkit 0.12.5 needs docker v25
https://github.com/moby/buildkit/blob/v0.12.5/go.mod#L31

But oras-go 1.2.4 breaks with newer docker so we need 1.2.5 (check Important in the release notes)

https://github.com/oras-project/oras-go/releases/tag/v1.2.5


the other one go.opentelemetry.io/otel/metric v0.38.0 => go.opentelemetry.io/otel/metric v0.34.0 is not useful anymore since we have metric v1.24.0 so the replace does nothing to sum.

@moukoublen moukoublen merged commit d2d6891 into elastic:main Apr 1, 2024
23 checks passed
@moukoublen moukoublen deleted the bump_buildkit_0.12.5 branch April 1, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants