-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Coverage badge flow #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i see the badge is corrected, but as as discussed:
-
Move the unit test back to cloud beat-ci, right now unit tests are running on main branch instead of the pr, effectively removing it as a quality gate for the pr, since u removed the pr checkout.
-
Add an additional workflow to be run post merge "on push to main" to run unit tests and update the badge representing status of coverage on main, and not the pr branch.
It isn't possible to achieve both from one workflow.
I'm not sure I'm following, I just split the same workflow into two separate ones with the same triggers. There is no reason to keep them together since they are logically separate, share no cache, and the yml is getting too large.
the readme will always show the badge for main, not for the PR branch. Why do we need post-merge job? |
Cloudbeat CI 🤖Integration tests status: success =========================== short test summary info ============================
PASSED integration/tests/test_output_to_elasticsearch.py::test_elastic_index_exists[file-system]
PASSED integration/tests/test_output_to_elasticsearch.py::test_elastic_index_exists[process]
PASSED integration/tests/test_output_to_elasticsearch.py::test_elastic_index_exists[kube-api]
PASSED product/tests/test_cloudbeat.py::test_cloudbeat_pod_exist
PASSED product/tests/test_cloudbeat.py::test_cloudbeat_pods_running
======================== 5 passed, 6 warnings in 1.62s ========================= Link to detailed report: https://elastic.github.io/cloudbeat/333 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Update Coverage badge flow using coveralls.io, see an example for my fork here
coveralls.io provides free service for tracking coverage for open source repos: