Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PostgreSQL] Remove duplicate PK check in advanced sync rules #2007

Merged
merged 4 commits into from
Dec 22, 2023
Merged

[PostgreSQL] Remove duplicate PK check in advanced sync rules #2007

merged 4 commits into from
Dec 22, 2023

Conversation

timgrein
Copy link
Contributor

Related to #2002

Removes the duplicate primary keys check in advanced sync rules for the PostgreSQL connector to enable JOINs, also when the primary keys of different tables are the same.

Checklists

Pre-Review Checklist

  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • if there is no GH issue, please create it. Each PR should have a link to an issue
  • this PR has a thorough description
  • Covered the changes with automated tests
  • Tested the changes locally
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)

@timgrein timgrein requested a review from a team as a code owner December 21, 2023 13:19
@timgrein
Copy link
Contributor Author

buildkite test this

1 similar comment
@timgrein
Copy link
Contributor Author

buildkite test this

@artem-shelkovnikov
Copy link
Member

@timgrein updating the branch from main should fix ftests for you

artem-shelkovnikov
artem-shelkovnikov approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@artem-shelkovnikov artem-shelkovnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a test for it too?

@artem-shelkovnikov artem-shelkovnikov merged commit ff0c177 into main Dec 22, 2023
2 checks passed
@artem-shelkovnikov artem-shelkovnikov deleted the timgrein/remove-duplicate-pk-check-postgresql branch December 22, 2023 14:20
@github-actions github-actions bot mentioned this pull request Dec 22, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Dec 22, 2023
@timgrein @artem-shelkovnikov
[PostgreSQL] Remove duplicate PK check in advanced sync rules (#2007)
f2a19da 
Co-authored-by: Artem Shelkovnikov <artem.shelkovnikov@elastic.co>
github-actions bot pushed a commit that referenced this pull request Dec 22, 2023
@timgrein @artem-shelkovnikov
[PostgreSQL] Remove duplicate PK check in advanced sync rules (#2007)
c35f9f7 
Co-authored-by: Artem Shelkovnikov <artem.shelkovnikov@elastic.co>
@github-actions github-actions bot mentioned this pull request Dec 22, 2023
Merged
@github-actions GitHub Actions
Copy link

💚 Backport PR(s) successfully created

Status Branch Result
✅ 8.11 #2014
✅ 8.12 #2015

The backport PRs will be merged automatically after passing CI.

artem-shelkovnikov added a commit that referenced this pull request Dec 22, 2023
@github-actions @timgrein @artem-shelkovnikov
[8.12] [PostgreSQL] Remove duplicate PK check in advanced sync rules (#…
b3199df 
…2007) (#2015)

Co-authored-by: Tim Grein <tim.grein@elastic.co>
Co-authored-by: Artem Shelkovnikov <artem.shelkovnikov@elastic.co>
artem-shelkovnikov added a commit that referenced this pull request Dec 22, 2023
@github-actions @timgrein @artem-shelkovnikov
[8.11] [PostgreSQL] Remove duplicate PK check in advanced sync rules (#…
7bad4b8 
…2007) (#2014)

Co-authored-by: Tim Grein <tim.grein@elastic.co>
Co-authored-by: Artem Shelkovnikov <artem.shelkovnikov@elastic.co>
This was referenced Feb 22, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artem-shelkovnikov artem-shelkovnikov artem-shelkovnikov approved these changes

Assignees
No one assigned
Labels
auto-backport v8.11.0 v8.11.0.0 v8.12.0 v8.12.0.0 v8.12.1 v8.13.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timgrein @artem-shelkovnikov