fix acl query template #2102
Merged
fix acl query template #2102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navarone-feekery
previously approved these changes
Jan 31, 2024
| }, | ||
| { | ||
| "terms": { | ||
| "_allow_access_control.enum": {{#toJson}}access_control{{/toJson}} |
There was a problem hiding this comment.
TIL about the toJson search template. Nice implementation!
There was a problem hiding this comment.
Credit goes to @ioanatia in her original DLS designs back in ~8.7
|
@navarone-feekery can I get a re-approval? |
seanstory
force-pushed
the
seanstory/fix-acl-query-template
branch
from
242b10d
to
d2fc41c
Compare
navarone-feekery
approved these changes
Feb 2, 2024
💔 Failed to create backport PR(s)The backport operation could not be completed due to the following error: The backport PRs will be merged automatically after passing CI. To backport manually run: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1696
In a review of the DLS + Internal Knowledge Search blog, @xeraa had commented that our DLS query looked overly complex. This sent me down a rabbit hole, first figuring out that our example DLS app was using an overly-complex query, then wondering why we were having to create an explicit query at all, then finally realizing I'd had these thoughts before and filed #1696 to eventually address the issue.
The time has come.
This PR removes the outer
bool: { filter: {clause that's no longer necessary (since Workplace Search) as we do not have a_deny_access_controlpattern for any of our connectors (yet).It also fixes the syntax of the output document so that the template contents can be directly taken and shoved into a role descriptor.
Checklists
Pre-Review Checklist
v7.13.2,v7.14.0,v8.0.0)Changes Requiring Extra Attention
Related Pull Requests
Release Note
Changes the output structure of the documents created by ACL Syncs. Now these docs are appropriately structured to create Role Descriptors. The structure to access the identity and its permissions have not changed. This structure can take up to half as much space to store as the previous structure.