Add * as default value for comma-separated lists that support it #2532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
navarone-feekery
previously approved these changes
May 8, 2024
share/man/man1/ttx.1
Outdated
| @@ -0,0 +1,225 @@ | |||
| .Dd May 18, 2004 | |||
There was a problem hiding this comment.
I'm really curious, what does this new file do? Or was it added by mistake?
There was a problem hiding this comment.
Idk how it got here, wat
There was a problem hiding this comment.
AH now it's gone, ignore ^
navarone-feekery
approved these changes
May 8, 2024
artem-shelkovnikov
added a commit
to elastic/kibana
that referenced
this pull request
May 8, 2024
## Summary This PR adds "*" as default value for 3 more native connector fields that specify comma-separate values: - MySQL connector field "tables" - Oracle connector field "tables" - Sharepoint Online field "site_collections" Similar PR in connectors: elastic/connectors#2532 ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 8, 2024
## Summary This PR adds "*" as default value for 3 more native connector fields that specify comma-separate values: - MySQL connector field "tables" - Oracle connector field "tables" - Sharepoint Online field "site_collections" Similar PR in connectors: elastic/connectors#2532 ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit b3e6f74)
kibanamachine
added a commit
to elastic/kibana
that referenced
this pull request
May 8, 2024
…182974) # Backport This will backport the following commits from `main` to `8.14`: - [Add * as default value for 3 more native connectors (#182957)](#182957) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Artem Shelkovnikov","email":"artem.shelkovnikov@elastic.co"},"sourceCommit":{"committedDate":"2024-05-08T16:29:41Z","message":"Add * as default value for 3 more native connectors (#182957)\n\n## Summary\r\n\r\nThis PR adds \"*\" as default value for 3 more native connector fields\r\nthat specify comma-separate values:\r\n\r\n- MySQL connector field \"tables\"\r\n- Oracle connector field \"tables\"\r\n- Sharepoint Online field \"site_collections\"\r\n\r\nSimilar PR in connectors:\r\nhttps://github.com/elastic/connectors/pull/2532\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"b3e6f74234298f5f042679fe043a8a5c8d067673","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.14.0","v8.15.0"],"title":"Add * as default value for 3 more native connectors","number":182957,"url":"#182957 * as default value for 3 more native connectors (#182957)\n\n## Summary\r\n\r\nThis PR adds \"*\" as default value for 3 more native connector fields\r\nthat specify comma-separate values:\r\n\r\n- MySQL connector field \"tables\"\r\n- Oracle connector field \"tables\"\r\n- Sharepoint Online field \"site_collections\"\r\n\r\nSimilar PR in connectors:\r\nhttps://github.com/elastic/connectors/pull/2532\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"b3e6f74234298f5f042679fe043a8a5c8d067673"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/182957","number":182957,"mergeCommit":{"message":"Add * as default value for 3 more native connectors (#182957)\n\n## Summary\r\n\r\nThis PR adds \"*\" as default value for 3 more native connector fields\r\nthat specify comma-separate values:\r\n\r\n- MySQL connector field \"tables\"\r\n- Oracle connector field \"tables\"\r\n- Sharepoint Online field \"site_collections\"\r\n\r\nSimilar PR in connectors:\r\nhttps://github.com/elastic/connectors/pull/2532\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"b3e6f74234298f5f042679fe043a8a5c8d067673"}}]}] BACKPORT--> Co-authored-by: Artem Shelkovnikov <artem.shelkovnikov@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/elastic/enterprise-search-team/issues/7205
This PR adds "*" as a default value for connector fields that support comma-separated values and asterisk. Affected connectors/fields are:
tablestablestablestablesdatabaseservicessite_collectionsChecklists
Pre-Review Checklist
config.yml.example)v7.13.2,v7.14.0,v8.0.0)Related Pull Requests
elastic/kibana#182957