Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme file with default attributes #166

Closed
holms opened this issue Nov 26, 2013 · 3 comments
Closed

update readme file with default attributes #166

holms opened this issue Nov 26, 2013 · 3 comments

Comments

@holms
Copy link

holms commented Nov 26, 2013

Sorry for bugging but I'm completely confused with your README.
Good example would be this cookbook: https://github.com/lusis/chef-logstash

Most setups goes with chef-server, instead of chef-solo. You proposed a node.json instead of role.json. That's fine it's not hard to use this in role also, but what I'm confused about is that I don't see any default attributes in readme. For example what this one does?

 "bootstrap.mlockall" : false

I could update readme my self, although I'm not sure if you'd be happy with that format as lusis/chef-logstash cookbook goes. I've noticed that plenty of cookbooks follows same pattern, for example the one from Opscode itself: https://github.com/opscode-cookbooks/openvpn

@karmi
Copy link
Contributor

karmi commented Dec 5, 2013

I'm sorry but I don't understand your point here. The Readme has a section on Chef Server deployments: https://github.com/elasticsearch/cookbook-elasticsearch#chef-server

"bootstrap.mlockall" : false is simply an Elasticsearch configuration value -- see the documentation.

To inspect the default attributes, just consult the attributes/default.rb file -- I don't see any reason to list and describe them in the Readme, since most of them map transparently to Elasticsearch configuration, and you need to consult the Elasticsearch documentation to understand them.

@holms
Copy link
Author

holms commented Dec 5, 2013

as far I've used any cookbook of chef which is on github, in readme there's usually full description of attributes/default.rb. see these:

https://github.com/opscode-cookbooks/openvpn
https://github.com/lusis/chef-logstash
https://github.com/alappe/cookbook-beaver

Thanks for pointing to elasticsearch docs

@karmi
Copy link
Contributor

karmi commented Feb 3, 2014

Hi, I'm sorry but I still maintain that simply listing all the attributes from default.rb (and other) files in the README doesn't bring much benefit to the end user, and would spoil the narrative of the README, which is focused on explaining usage of the cookbook.

I'm quite familiar with most cookbooks listing all (or almost all) attributes in the README, and don't want to go that route in this cookbook.

If you'd like to discuss the issue further, let's continue here or ping me at IRC!

@karmi karmi closed this as completed Feb 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants