pid_path is owned by elasticsearch

[kamaradclimber]

since a95a3f7, default pid_path attribute is /usr/local/var/run.
However the default recipe define this as directory resource and specify that user/group owners are elasticsearch.
This directory should belongs to root and allow elasticsearch to write its pid.

[kamaradclimber]

in https://github.com/elasticsearch/elasticsearch/blob/master/src/deb/init.d/elasticsearch#L152, we can see the pid file being created by the init.d script and chown to elasticsearch.

@karmi would you consider a patch to fix this behavior ?

[karmi]

I believe you mean this line?

The location has been changed because of discussion in #108.

So the expression in default.rb#L40 is problematic.

The problem is that we can't actually blindly chown the node.elasticsearch. pid_path to Elasticsearch. Chowning it to root probably makes some sense, but would like to see some feedback/research around it first...

[kamaradclimber]

a way to fix this would be to specify the pid_path directory resource without specifying the owner/group. This would let existing value if the directroy already exists or give it to root if created by chef.
Then in the init.d file, we chown pid_file (not pid_path) to give it to elasticsearch user.

the current default of pid_path is a directory used by several applications (not only elasticsearch), giving it to elasticsearch user breaks these other applications.

[karmi]

the current default of pid_path is a directory used by several applications (not only elasticsearch), giving it to elasticsearch user breaks these other applications.

Agreed, this shouldn't happen. Chowning the PID file in the init script is safe.

[kamaradclimber]

do you need me to change anything in this PR ?

[karmi]

@kamaradclimber Sorry, tied up with something else right now, I'll try to process the cookbooks PR soon... Would like to verify it, even though the code change is very simple.

[karmi]

Hi, thanks for the patch!, merged it in!