Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align elasticsearch-env.sh.erb with elasticsearch.in.sh #3

Closed
kimchy opened this issue Jan 7, 2012 · 1 comment
Closed

Align elasticsearch-env.sh.erb with elasticsearch.in.sh #3

kimchy opened this issue Jan 7, 2012 · 1 comment

Comments

@kimchy
Copy link

kimchy commented Jan 7, 2012

I suggest aligning elasticsearch-env.sh.erb with elasticsearch.in.sh that comes with elasticsearch installation. There is no need to use the max-open-files flag for example (its exposed in nodes info), AgressiveOpts is no longer recommended, and there are other flags in https://github.com/elasticsearch/elasticsearch/blob/master/bin/elasticsearch.in.sh that are recommended.

@karmi karmi closed this as completed in 313b1dc Jan 8, 2012
@karmi
Copy link
Contributor

karmi commented Jan 8, 2012

Yes, thanks for the nudge. I've copied over some configs from the Opscode cookbook. It would probably make sense to just use the provided file and somehow allow user to override it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants