Merge pull request #834 from untergeek/fix/829

Change wait_for_completion default for snapshot
elastic · Dec 7, 2016 · a403a39 · a403a39
2 parents 3af4678 + c055190
commit a403a39
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 3 deletions.
diff --git a/curator/_version.py b/curator/_version.py
@@ -1 +1 @@
-__version__ = '4.2.3.post1'
+__version__ = '4.2.4.dev1'
diff --git a/curator/singletons.py b/curator/singletons.py
@@ -465,7 +465,9 @@ def replicas_singleton(
     help='Do not fail if primary shard is unavailable.'
 )
 @click.option(
-    '--wait_for_completion', is_flag=True, help='Wait for operation to complete'
+    '--wait_for_completion',
+    type=bool, show_default=True, default=True,
+    help='Wait for operation to complete'
 )
 @click.option(
     '--skip_repo_fs_check', is_flag=True, expose_value=True,

diff --git a/docs/Changelog.rst b/docs/Changelog.rst
@@ -3,6 +3,14 @@
 Changelog
 =========
 
+4.2.4 (? ? ?)
+-------------
+
+**Bug Fixes**
+
+  * ``--wait_for_completion`` should be `True` by default for Snapshot singleton
+    action.  Reported in #829 (untergeek)
+
 4.2.3.post1 (22 November 2016)
 ------------------------------
 

diff --git a/docs/asciidoc/index.asciidoc b/docs/asciidoc/index.asciidoc
@@ -1,4 +1,4 @@
-:curator_version: 4.2.3
+:curator_version: 4.2.4
 :curator_major: 4
 :es_py_version: 2.4.0
 :ref:  http://www.elastic.co/guide/en/elasticsearch/reference/current