Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump urllib3 to 1.26.5 #1610

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Conversation

tsaarni
Copy link
Contributor

@tsaarni tsaarni commented Jun 23, 2021

Updates version of urllib3 dependency to 1.26.5 to avoid GHSA-q2q7-5pp4-w6pg.

Fixes #1609

@srietkerk
Copy link

Hi, if this PR could be approved and merged that would be great! I am working on a project where elasticsearch-curator's hard dependency on urllib3 v1.26.4 is causing a high severity security vulnerability.

@untergeek
Copy link
Member

untergeek commented Jul 7, 2021 via email

@srietkerk
Copy link

Hi! I just wanted to check-in about this update since it's been a bit. Hope all is well!

@mau-alex-ruiz
Copy link

Also bumping this, thanks!

@mau-alex-ruiz
Copy link

Hi @untergeek, just inquiring when this is expected to get merged 👍

@untergeek
Copy link
Member

Just barely back from time off for a death in the family, as well as a wedding. Hopefully can address in the next few days.

@untergeek untergeek merged commit 0fecc64 into elastic:master Aug 10, 2021
@mau-alex-ruiz
Copy link

@untergeek It looks like ci/cd failed due to an elasticsearch client incompatibility. You can read about it here:
https://www-theregister-com.cdn.ampproject.org/c/s/www.theregister.com/AMP/2021/08/09/elasticsearch_python_client_change/

The issue arose in elasticsearch version 7.14.0, so it could be good to cap the version as <7.14.0 to avoid the issue for now.

@mau-alex-ruiz
Copy link

Also, is there any time estimate on when the next elasticsearch-curator version will be released so that we can consume these changes? Thanks :)

@tsaarni
Copy link
Contributor Author

tsaarni commented Aug 10, 2021

Ah sorry, back when I did the PR it still passed CI successfully - it was before the latest licensing issues. Does not pass anymore, like @mau-alex-ruiz pointed out (https://travis-ci.org/github/elastic/curator/jobs/774705198)

UnsupportedProductError: The client noticed that the server is not Elasticsearch and we do not support this unknown product

I guess in this particular case, dropping ES 5.x.x support could be another alternative.

@untergeek
Copy link
Member

Not worried about the client issue. 5.6 is so old I'm removing testing for that. Anyone still needing to use 5.6 can use v5.8.4 or older. The current PR undergoing testing has stripped that out, and bumped a few other dependent modules. We'll see how that shakes out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump urllib3 version
4 participants