Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python's build in unittest.mock #1652

Closed
wants to merge 1 commit into from
Closed

Conversation

jelly
Copy link
Contributor

@jelly jelly commented Nov 12, 2022

Since Python 3.3 the unittest module supports mock and replaces python-mock which is now deprecated.

Fixes #

Proposed Changes

  • Stop using the deprecated mock module and use the Python unittest.mock module

Since Python 3.3 the unittest module supports mock and replaces
python-mock which is now deprecated.
@cla-checker-service
Copy link

cla-checker-service bot commented Nov 12, 2022

💚 CLA has been signed

@untergeek
Copy link
Member

I appreciate the effort, but you should check out the 6.x and 7.x branches of Curator. I haven't updated master as I am working on a very new, very different 8.x branch at the same time.

@jelly
Copy link
Contributor Author

jelly commented Nov 12, 2022

Ok, I'll close this PR then.

@jelly jelly closed this Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants