Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tuning] Linux BBR Tuning - Part 2 #3470

Merged
merged 7 commits into from
Mar 7, 2024
Merged

Conversation

Aegrah
Copy link
Contributor

@Aegrah Aegrah commented Feb 22, 2024

Summary

Part 2 of the Linux BBR DR tuning. Besides regular rule tuning, this PR added compatibility with additional data sources where possible, added correct tags/indices, fixed formatting, and checked for potential rule performance increases.

Copy link
Contributor

@DefSecSentinel DefSecSentinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aegrah Aegrah merged commit 7a09679 into main Mar 7, 2024
14 checks passed
@Aegrah Aegrah deleted the linux-building-block-rule-tuning-2 branch March 7, 2024 11:35
protectionsmachine pushed a commit that referenced this pull request Mar 7, 2024
* [Tuning] Linux BBR Tuning - Part 2

* Update discovery_of_accounts_or_groups_via_builtin_tools.toml

* Update discovery_process_discovery_via_builtin_tools.toml

* Update discovery_hosts_file_access.toml

* Update discovery_system_network_connections.toml

---------

Co-authored-by: Colson Wilhoit <48036388+DefSecSentinel@users.noreply.github.com>

Removed changes from:
- rules_building_block/discovery_kernel_module_enumeration_via_proc.toml
- rules_building_block/discovery_linux_modprobe_enumeration.toml
- rules_building_block/discovery_linux_sysctl_enumeration.toml

(selectively cherry picked from commit 7a09679)
protectionsmachine pushed a commit that referenced this pull request Mar 7, 2024
* [Tuning] Linux BBR Tuning - Part 2

* Update discovery_of_accounts_or_groups_via_builtin_tools.toml

* Update discovery_process_discovery_via_builtin_tools.toml

* Update discovery_hosts_file_access.toml

* Update discovery_system_network_connections.toml

---------

Co-authored-by: Colson Wilhoit <48036388+DefSecSentinel@users.noreply.github.com>

Removed changes from:
- rules_building_block/discovery_kernel_module_enumeration_via_proc.toml
- rules_building_block/discovery_linux_modprobe_enumeration.toml
- rules_building_block/discovery_linux_sysctl_enumeration.toml

(selectively cherry picked from commit 7a09679)
protectionsmachine pushed a commit that referenced this pull request Mar 7, 2024
* [Tuning] Linux BBR Tuning - Part 2

* Update discovery_of_accounts_or_groups_via_builtin_tools.toml

* Update discovery_process_discovery_via_builtin_tools.toml

* Update discovery_hosts_file_access.toml

* Update discovery_system_network_connections.toml

---------

Co-authored-by: Colson Wilhoit <48036388+DefSecSentinel@users.noreply.github.com>

Removed changes from:
- rules_building_block/discovery_kernel_module_enumeration_via_proc.toml
- rules_building_block/discovery_linux_modprobe_enumeration.toml
- rules_building_block/discovery_linux_sysctl_enumeration.toml

(selectively cherry picked from commit 7a09679)
protectionsmachine pushed a commit that referenced this pull request Mar 7, 2024
* [Tuning] Linux BBR Tuning - Part 2

* Update discovery_of_accounts_or_groups_via_builtin_tools.toml

* Update discovery_process_discovery_via_builtin_tools.toml

* Update discovery_hosts_file_access.toml

* Update discovery_system_network_connections.toml

---------

Co-authored-by: Colson Wilhoit <48036388+DefSecSentinel@users.noreply.github.com>

(cherry picked from commit 7a09679)
protectionsmachine pushed a commit that referenced this pull request Mar 7, 2024
* [Tuning] Linux BBR Tuning - Part 2

* Update discovery_of_accounts_or_groups_via_builtin_tools.toml

* Update discovery_process_discovery_via_builtin_tools.toml

* Update discovery_hosts_file_access.toml

* Update discovery_system_network_connections.toml

---------

Co-authored-by: Colson Wilhoit <48036388+DefSecSentinel@users.noreply.github.com>

(cherry picked from commit 7a09679)
protectionsmachine pushed a commit that referenced this pull request Mar 7, 2024
* [Tuning] Linux BBR Tuning - Part 2

* Update discovery_of_accounts_or_groups_via_builtin_tools.toml

* Update discovery_process_discovery_via_builtin_tools.toml

* Update discovery_hosts_file_access.toml

* Update discovery_system_network_connections.toml

---------

Co-authored-by: Colson Wilhoit <48036388+DefSecSentinel@users.noreply.github.com>

(cherry picked from commit 7a09679)
protectionsmachine pushed a commit that referenced this pull request Mar 7, 2024
* [Tuning] Linux BBR Tuning - Part 2

* Update discovery_of_accounts_or_groups_via_builtin_tools.toml

* Update discovery_process_discovery_via_builtin_tools.toml

* Update discovery_hosts_file_access.toml

* Update discovery_system_network_connections.toml

---------

Co-authored-by: Colson Wilhoit <48036388+DefSecSentinel@users.noreply.github.com>

(cherry picked from commit 7a09679)
protectionsmachine pushed a commit that referenced this pull request Mar 7, 2024
* [Tuning] Linux BBR Tuning - Part 2

* Update discovery_of_accounts_or_groups_via_builtin_tools.toml

* Update discovery_process_discovery_via_builtin_tools.toml

* Update discovery_hosts_file_access.toml

* Update discovery_system_network_connections.toml

---------

Co-authored-by: Colson Wilhoit <48036388+DefSecSentinel@users.noreply.github.com>

(cherry picked from commit 7a09679)
protectionsmachine pushed a commit that referenced this pull request Mar 7, 2024
* [Tuning] Linux BBR Tuning - Part 2

* Update discovery_of_accounts_or_groups_via_builtin_tools.toml

* Update discovery_process_discovery_via_builtin_tools.toml

* Update discovery_hosts_file_access.toml

* Update discovery_system_network_connections.toml

---------

Co-authored-by: Colson Wilhoit <48036388+DefSecSentinel@users.noreply.github.com>

(cherry picked from commit 7a09679)
protectionsmachine pushed a commit that referenced this pull request Mar 7, 2024
* [Tuning] Linux BBR Tuning - Part 2

* Update discovery_of_accounts_or_groups_via_builtin_tools.toml

* Update discovery_process_discovery_via_builtin_tools.toml

* Update discovery_hosts_file_access.toml

* Update discovery_system_network_connections.toml

---------

Co-authored-by: Colson Wilhoit <48036388+DefSecSentinel@users.noreply.github.com>

(cherry picked from commit 7a09679)
protectionsmachine pushed a commit that referenced this pull request Mar 7, 2024
* [Tuning] Linux BBR Tuning - Part 2

* Update discovery_of_accounts_or_groups_via_builtin_tools.toml

* Update discovery_process_discovery_via_builtin_tools.toml

* Update discovery_hosts_file_access.toml

* Update discovery_system_network_connections.toml

---------

Co-authored-by: Colson Wilhoit <48036388+DefSecSentinel@users.noreply.github.com>

(cherry picked from commit 7a09679)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants