-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tuning] Linux BBR Tuning - Part 2 #3470
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aegrah
added
OS: Linux
Rule: Tuning
tweaking or tuning an existing rule
Domain: Endpoint
backport: auto
Area: RAD
Team: TRADE
labels
Feb 22, 2024
Aegrah
requested review from
w0rk3r,
DefSecSentinel,
shashank-elastic and
terrancedejesus
February 22, 2024 13:00
DefSecSentinel
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
w0rk3r
approved these changes
Mar 6, 2024
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 7, 2024
* [Tuning] Linux BBR Tuning - Part 2 * Update discovery_of_accounts_or_groups_via_builtin_tools.toml * Update discovery_process_discovery_via_builtin_tools.toml * Update discovery_hosts_file_access.toml * Update discovery_system_network_connections.toml --------- Co-authored-by: Colson Wilhoit <48036388+DefSecSentinel@users.noreply.github.com> Removed changes from: - rules_building_block/discovery_kernel_module_enumeration_via_proc.toml - rules_building_block/discovery_linux_modprobe_enumeration.toml - rules_building_block/discovery_linux_sysctl_enumeration.toml (selectively cherry picked from commit 7a09679)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 7, 2024
* [Tuning] Linux BBR Tuning - Part 2 * Update discovery_of_accounts_or_groups_via_builtin_tools.toml * Update discovery_process_discovery_via_builtin_tools.toml * Update discovery_hosts_file_access.toml * Update discovery_system_network_connections.toml --------- Co-authored-by: Colson Wilhoit <48036388+DefSecSentinel@users.noreply.github.com> Removed changes from: - rules_building_block/discovery_kernel_module_enumeration_via_proc.toml - rules_building_block/discovery_linux_modprobe_enumeration.toml - rules_building_block/discovery_linux_sysctl_enumeration.toml (selectively cherry picked from commit 7a09679)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 7, 2024
* [Tuning] Linux BBR Tuning - Part 2 * Update discovery_of_accounts_or_groups_via_builtin_tools.toml * Update discovery_process_discovery_via_builtin_tools.toml * Update discovery_hosts_file_access.toml * Update discovery_system_network_connections.toml --------- Co-authored-by: Colson Wilhoit <48036388+DefSecSentinel@users.noreply.github.com> Removed changes from: - rules_building_block/discovery_kernel_module_enumeration_via_proc.toml - rules_building_block/discovery_linux_modprobe_enumeration.toml - rules_building_block/discovery_linux_sysctl_enumeration.toml (selectively cherry picked from commit 7a09679)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 7, 2024
* [Tuning] Linux BBR Tuning - Part 2 * Update discovery_of_accounts_or_groups_via_builtin_tools.toml * Update discovery_process_discovery_via_builtin_tools.toml * Update discovery_hosts_file_access.toml * Update discovery_system_network_connections.toml --------- Co-authored-by: Colson Wilhoit <48036388+DefSecSentinel@users.noreply.github.com> (cherry picked from commit 7a09679)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 7, 2024
* [Tuning] Linux BBR Tuning - Part 2 * Update discovery_of_accounts_or_groups_via_builtin_tools.toml * Update discovery_process_discovery_via_builtin_tools.toml * Update discovery_hosts_file_access.toml * Update discovery_system_network_connections.toml --------- Co-authored-by: Colson Wilhoit <48036388+DefSecSentinel@users.noreply.github.com> (cherry picked from commit 7a09679)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 7, 2024
* [Tuning] Linux BBR Tuning - Part 2 * Update discovery_of_accounts_or_groups_via_builtin_tools.toml * Update discovery_process_discovery_via_builtin_tools.toml * Update discovery_hosts_file_access.toml * Update discovery_system_network_connections.toml --------- Co-authored-by: Colson Wilhoit <48036388+DefSecSentinel@users.noreply.github.com> (cherry picked from commit 7a09679)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 7, 2024
* [Tuning] Linux BBR Tuning - Part 2 * Update discovery_of_accounts_or_groups_via_builtin_tools.toml * Update discovery_process_discovery_via_builtin_tools.toml * Update discovery_hosts_file_access.toml * Update discovery_system_network_connections.toml --------- Co-authored-by: Colson Wilhoit <48036388+DefSecSentinel@users.noreply.github.com> (cherry picked from commit 7a09679)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 7, 2024
* [Tuning] Linux BBR Tuning - Part 2 * Update discovery_of_accounts_or_groups_via_builtin_tools.toml * Update discovery_process_discovery_via_builtin_tools.toml * Update discovery_hosts_file_access.toml * Update discovery_system_network_connections.toml --------- Co-authored-by: Colson Wilhoit <48036388+DefSecSentinel@users.noreply.github.com> (cherry picked from commit 7a09679)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 7, 2024
* [Tuning] Linux BBR Tuning - Part 2 * Update discovery_of_accounts_or_groups_via_builtin_tools.toml * Update discovery_process_discovery_via_builtin_tools.toml * Update discovery_hosts_file_access.toml * Update discovery_system_network_connections.toml --------- Co-authored-by: Colson Wilhoit <48036388+DefSecSentinel@users.noreply.github.com> (cherry picked from commit 7a09679)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 7, 2024
* [Tuning] Linux BBR Tuning - Part 2 * Update discovery_of_accounts_or_groups_via_builtin_tools.toml * Update discovery_process_discovery_via_builtin_tools.toml * Update discovery_hosts_file_access.toml * Update discovery_system_network_connections.toml --------- Co-authored-by: Colson Wilhoit <48036388+DefSecSentinel@users.noreply.github.com> (cherry picked from commit 7a09679)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 7, 2024
* [Tuning] Linux BBR Tuning - Part 2 * Update discovery_of_accounts_or_groups_via_builtin_tools.toml * Update discovery_process_discovery_via_builtin_tools.toml * Update discovery_hosts_file_access.toml * Update discovery_system_network_connections.toml --------- Co-authored-by: Colson Wilhoit <48036388+DefSecSentinel@users.noreply.github.com> (cherry picked from commit 7a09679)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: RAD
backport: auto
bbr
Building Block Rules
Domain: Endpoint
OS: Linux
Rule: Tuning
tweaking or tuning an existing rule
Team: TRADE
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part 2 of the Linux BBR DR tuning. Besides regular rule tuning, this PR added compatibility with additional data sources where possible, added correct tags/indices, fixed formatting, and checked for potential rule performance increases.