Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boilerplate for EOL/OOM notices. #1426

Merged
merged 1 commit into from Nov 20, 2019
Merged

Boilerplate for EOL/OOM notices. #1426

merged 1 commit into from Nov 20, 2019

Conversation

debadair
Copy link
Contributor

The default banner for versions older than the current version does not distinguish between versions that are still being actively maintained and versions that are out of maintenance or EOL.

Changes that we've been discussing around our backporting policy, "live" docs, and sunsetting old versions mean we need to more clearly communicate to readers when they are looking at a version that is OOM or EOL.

The intent is that these boilerplate messages will be set on a per-version basis for stack docs that have reached OOM or EOL. Going forward, we'll need some process for adding the notices as versions age.

Out of maintenance notice:
image

EOL notice:
image

Relates to: #1407, #1419, elastic/elasticsearch#49131

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm2

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@debadair debadair merged commit 6cf9e4d into elastic:master Nov 20, 2019
@debadair debadair mentioned this pull request Nov 20, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants