-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated shebang to explicitly state python3 (to work via WSL) #2274
Conversation
@nik9000 as the author of this fabulous story, I'm curious if you have any thoughts about this. I don't have an Arch system to test on, but I'd like to make the docs compatible with WSL for @ollyhowell and anyone else on Windows. I suppose an alternative would be to make |
If it works on Mac and Windows that's fine. Arch certainly has We should probably drop the story of the shebang and the reference to pep-394 too. |
Thanks @nik9000 . I misread the comment. I didn't realize it was macOS that could be the problem. It looks like there's a builtin ❯ /usr/bin/python3
Python 3.8.2 (default, Apr 8 2021, 23:19:18)
[Clang 12.0.5 (clang-1205.0.22.9)] on darwin
Type "help", "copyright", "credits" or "license" for more information. |
LGTM then
…On Mon, Nov 8, 2021 at 4:57 PM Greg Back ***@***.***> wrote:
Thanks @nik9000 <https://github.com/nik9000> . I misread the comment. I
didn't realize it was macOS that could be the problem. It looks like
there's a builtin python3 command on macOS (I have homebrew, pyenv, and a
bunch of other Pythons installed, but this one looks Apple-provided):
❯ /usr/bin/python3
Python 3.8.2 (default, Apr 8 2021, 23:19:18)
[Clang 12.0.5 (clang-1205.0.22.9)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2274 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABUXITIHQ2FJBBOZ5HJKA3ULBBVXANCNFSM5HEWMAIQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
I ended up just ripping out all the Python 2 support If that causes problems for anyone, we should fix their environments (I'll help with this) rather than continuing to support Python 2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Is running via Windows WSL documented? Prerequisites and example commands would be great. Thank you. |
@justincr-elastic Nope, not documented anywhere as far as I know. @ollyhowell is the only person I know who's using Windows/WSL, so if you're able to work with him and write some documentation, that would be great! |
No description provided.