Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated shebang to explicitly state python3 (to work via WSL) #2274

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

ollyhowell
Copy link
Contributor

No description provided.

@gtback
Copy link
Member

gtback commented Nov 5, 2021

@nik9000 as the author of this fabulous story, I'm curious if you have any thoughts about this. I don't have an Arch system to test on, but I'd like to make the docs compatible with WSL for @ollyhowell and anyone else on Windows.

I suppose an alternative would be to make ./build_docs into a shell script that detects the Python interpreter and then calls a ./build_docs.py which is a renamed version of the existing ./build_docs script.

@nik9000
Copy link
Member

nik9000 commented Nov 5, 2021

If it works on Mac and Windows that's fine. Arch certainly has python3. I chose python because, at least at the time, some Mac didn't have a python3. I don't even remember which one. But if Mac is fine with python3 now that'd be great. We can drop python2 support entirely.

We should probably drop the story of the shebang and the reference to pep-394 too.

@gtback
Copy link
Member

gtback commented Nov 8, 2021

Thanks @nik9000 . I misread the comment. I didn't realize it was macOS that could be the problem. It looks like there's a builtin python3 command on macOS (I have homebrew, pyenv, and a bunch of other Pythons installed, but this one looks Apple-provided):

❯ /usr/bin/python3
Python 3.8.2 (default, Apr  8 2021, 23:19:18)
[Clang 12.0.5 (clang-1205.0.22.9)] on darwin
Type "help", "copyright", "credits" or "license" for more information.

@nik9000
Copy link
Member

nik9000 commented Nov 8, 2021 via email

@gtback
Copy link
Member

gtback commented Nov 9, 2021

I ended up just ripping out all the Python 2 support

If that causes problems for anyone, we should fix their environments (I'll help with this) rather than continuing to support Python 2.

Copy link
Member

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gtback gtback merged commit db89895 into master Nov 9, 2021
@gtback gtback deleted the ollyhowell-docs branch November 9, 2021 23:11
@justincr-elastic
Copy link

Is running via Windows WSL documented? Prerequisites and example commands would be great. Thank you.

@gtback
Copy link
Member

gtback commented Mar 28, 2022

@justincr-elastic Nope, not documented anywhere as far as I know. @ollyhowell is the only person I know who's using Windows/WSL, so if you're able to work with him and write some documentation, that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants