Igor api key validation #1783

IgorGuz2000 · 2021-11-05T20:43:27Z

What does this PR do?

This PR test communication API keys are invalidated during unenrollment

Why is it important?

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have run the Unit tests (make unit-test), and they are passing locally
I have run the End-2-End tests for the suite I'm working on, and they are passing locally
I have noticed new Go dependencies (run make notice in the proper directory)

Author's Checklist

[ ]

How to test this PR locally

Related issues

#1192

…dation

mergify · 2021-11-05T20:43:52Z

This pull request does not have a backport label. Could you fix it @IgorGuz2000? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit
NOTE: backport-skip has been added to this pull request.

elasticmachine · 2021-11-05T20:48:50Z

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-01-20T19:14:05.289+0000
Duration: 62 min 18 sec
Commit: b60ad26

Test stats 🧪

Test	Results
Failed	5
Passed	219
Skipped	0
Total	224

Test errors

Expand to view the tests failures

`Initializing / End-To-End Tests / fleet_amd64_fleet_mode_agent / Un-enrolling with revoke agent deactivates the agent – Fleet Mode Agent`

Expand to view the error details

 Step the agent Api key invalidated "true": The agent Api key invalidated is should be: true

no stacktrace

`Initializing / End-To-End Tests / kubernetes_autodiscover_elastic-agent / [empty] – TEST-x86_64-kubernetes-autodiscover-79e77bf2-2022-01-20-19:34:32.xml`

no error details

Expand to view the stacktrace

 Test report file /var/lib/jenkins/workspace/PR-1783-28-6b7ada2c-9a89-4900-a9c1-664d262ec71e/outputs/18.219.45.37/TEST-x86_64-kubernetes-autodiscover-79e77bf2-2022-01-20-19:34:32.xml was length 0

`Initializing / End-To-End Tests / fleet_arm64_fleet_mode_agent / Deploying the agent with enroll and then run on rpm and deb – Fleet Mode Agent`

Expand to view the error details

 Step an agent is deployed to Fleet

no stacktrace

`Initializing / End-To-End Tests / fleet_sles15_fleet_mode_agent / Deploying the agent with enroll and then run on rpm and deb – Fleet Mode Agent`

Expand to view the error details

 Step an agent is deployed to Fleet

no stacktrace

`Initializing / End-To-End Tests / fleet_amd64_fleet_mode_agent / Deploying the agent with enroll and then run on rpm and deb – Fleet Mode Agent`

Expand to view the error details

 Step an agent is deployed to Fleet

no stacktrace

Steps errors

Expand to view the steps failures

`Shell Script`

Took 21 min 12 sec . View more details here
Description: ssh -tt -o TCPKeepAlive=yes -o ServerAliveInterval=60 -o ServerAliveCountMax=10 -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i /var/lib/jenkins/workspace/PR-1783-28-301e8c3e-560b-4392-87e5-60b0a23831fc/e2essh admin@18.117.219.110 -- 'sudo bash /home/admin/e2e-testing/.ci/scripts/functional-test.sh "fleet_mode_agent && ~@nightly && ~@skip:amd64" '

`Archive the artifacts`

Took 0 min 0 sec . View more details here
Description: [2022-01-20T19:54:48.168Z] Archiving artifacts script returned exit code 2

🐛 Flaky test report

❕ There are test failures but not known flaky tests.

Expand to view the summary

Genuine test errors

💔 There are test failures but not known flaky tests, most likely a genuine test failure.

Name: Initializing / End-To-End Tests / fleet_amd64_fleet_mode_agent / Un-enrolling with revoke agent deactivates the agent – Fleet Mode Agent
Name: Initializing / End-To-End Tests / kubernetes_autodiscover_elastic-agent / [empty] – TEST-x86_64-kubernetes-autodiscover-79e77bf2-2022-01-20-19:34:32.xml
Name: Initializing / End-To-End Tests / fleet_arm64_fleet_mode_agent / Deploying the agent with enroll and then run on rpm and deb – Fleet Mode Agent
Name: Initializing / End-To-End Tests / fleet_sles15_fleet_mode_agent / Deploying the agent with enroll and then run on rpm and deb – Fleet Mode Agent
Name: Initializing / End-To-End Tests / fleet_amd64_fleet_mode_agent / Deploying the agent with enroll and then run on rpm and deb – Fleet Mode Agent

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

…or_API_Key_validation

e2e/_suites/fleet/fleet.go

internal/elasticsearch/client.go

adam-stokes · 2021-11-11T18:40:34Z

Just a note to hold off on merging this until #1740 is merged as this PR will need some cleanup on the feature file @IgorGuz2000 @mdelapenya

…dation

…or_API_Key_validation

…dation

mdelapenya

I added a few comments

I agree with @adam-stokes in delaying the merge until #1740 is merged (which will be very soon)

internal/kibana/agents.go

IgorGuz2000 · 2021-11-18T23:20:30Z

Waiting for the #1740 to be merged

mergify · 2021-11-30T19:20:18Z

This pull request is now in conflict. Could you fix it @IgorGuz2000? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b Igor_API_Key_validation upstream/Igor_API_Key_validation
git merge upstream/master
git push upstream Igor_API_Key_validation

…dation # Conflicts: # e2e/_suites/fleet/features/fleet_mode_agent.feature

…or_API_Key_validation

internal/elasticsearch/client.go

e2e/_suites/fleet/features/fleet_mode_agent.feature

…dation

mergify · 2022-03-29T11:39:31Z

This pull request is now in conflict. Could you fix it @IgorGuz2000? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b Igor_API_Key_validation upstream/Igor_API_Key_validation
git merge upstream/main
git push upstream Igor_API_Key_validation

mergify · 2022-09-27T14:23:27Z

This pull request is now in conflict. Could you fix it @IgorGuz2000? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b Igor_API_Key_validation upstream/Igor_API_Key_validation
git merge upstream/main
git push upstream Igor_API_Key_validation

mergify · 2023-04-03T07:06:22Z

This pull request is now in conflict. Could you fix it @IgorGuz2000? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b Igor_API_Key_validation upstream/Igor_API_Key_validation
git merge upstream/main
git push upstream Igor_API_Key_validation

mergify · 2023-08-21T22:32:48Z

This pull request is now in conflict. Could you fix it @IgorGuz2000? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b Igor_API_Key_validation upstream/Igor_API_Key_validation
git merge upstream/main
git push upstream Igor_API_Key_validation

mergify · 2023-11-01T08:01:51Z

This pull request is now in conflict. Could you fix it @IgorGuz2000? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b Igor_API_Key_validation upstream/Igor_API_Key_validation
git merge upstream/main
git push upstream Igor_API_Key_validation

mergify · 2023-12-14T11:46:25Z

This pull request is now in conflict. Could you fix it @IgorGuz2000? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b Igor_API_Key_validation upstream/Igor_API_Key_validation
git merge upstream/main
git push upstream Igor_API_Key_validation

mergify · 2024-02-20T11:31:39Z

This pull request is now in conflict. Could you fix it @IgorGuz2000? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b Igor_API_Key_validation upstream/Igor_API_Key_validation
git merge upstream/main
git push upstream Igor_API_Key_validation

IgorGuz2000 added 4 commits November 2, 2021 11:38

Change the Scenarios description

d619871

Merge remote-tracking branch 'upstream/master' into Igor_API_Key_vali…

5619378

…dation

adding to scenario file

b85417a

adding to scenario file

1fafae8

IgorGuz2000 added area:test Anything related to the Test automation 8.0-candidate 7.16-candidate labels Nov 5, 2021

mergify bot added the backport-skip Skip notification from the automated backport with mergify label Nov 5, 2021

IgorGuz2000 and others added 2 commits November 5, 2021 13:46

Changing Scenario Names and tag

48a293e

Merge branch 'master' into Igor_API_Key_validation

4fcda4e

IgorGuz2000 added backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify labels Nov 5, 2021

mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Nov 5, 2021

IgorGuz2000 added 2 commits November 8, 2021 09:36

Changing step description to true

797705c

Merge remote-tracking branch 'origin/Igor_API_Key_validation' into Ig…

425a07c

…or_API_Key_validation

adam-stokes reviewed Nov 9, 2021

View reviewed changes

e2e/_suites/fleet/fleet.go Show resolved Hide resolved

adam-stokes requested changes Nov 9, 2021

View reviewed changes

internal/elasticsearch/client.go Outdated Show resolved Hide resolved

IgorGuz2000 and others added 2 commits November 9, 2021 22:40

Removing comment out lines

45e4906

Merge branch 'master' into Igor_API_Key_validation

314f5c1

IgorGuz2000 and others added 8 commits November 11, 2021 11:50

Merge remote-tracking branch 'upstream/master' into Igor_API_Key_vali…

0408187

…dation

Merge remote-tracking branch 'upstream/master' into Igor_API_Key_vali…

5085a8a

…dation

Merge branch 'master' into Igor_API_Key_validation

c4b80e3

Merge remote-tracking branch 'upstream/master' into Igor_API_Key_vali…

491337c

…dation

Fixed per comments by Adam

41f0b52

Merge remote-tracking branch 'origin/Igor_API_Key_validation' into Ig…

1a3e166

…or_API_Key_validation

Merge remote-tracking branch 'upstream/master' into Igor_API_Key_vali…

add18ed

…dation

Remove unused url prefix

98da734

mdelapenya reviewed Nov 17, 2021

View reviewed changes

internal/kibana/agents.go Outdated Show resolved Hide resolved

IgorGuz2000 and others added 2 commits November 18, 2021 10:00

removed functions using gabs, and converted to struct

81e3395

Merge branch 'master' into Igor_API_Key_validation

aee3cc7

Merge branch 'master' into Igor_API_Key_validation

afeee1b

IgorGuz2000 added 3 commits November 30, 2021 13:18

Merge remote-tracking branch 'upstream/master' into Igor_API_Key_vali…

d4b6240

…dation # Conflicts: # e2e/_suites/fleet/features/fleet_mode_agent.feature

Merge remote-tracking branch 'origin/Igor_API_Key_validation' into Ig…

fb2e52a

…or_API_Key_validation

commiting changes from master

fafad6b

adam-stokes requested changes Dec 1, 2021

View reviewed changes

IgorGuz2000 and others added 13 commits December 1, 2021 08:36

Merge remote-tracking branch 'upstream/master' into Igor_API_Key_vali…

80ad66e

…dation

commiting changes from master

505a7de

Removing os from the scenarios

11d2bca

Changing to support remote provider

1593067

Merge branch 'master' into Igor_API_Key_validation

d15774c

Merge branch 'master' into Igor_API_Key_validation

bc2b638

Merge branch 'master' into Igor_API_Key_validation

d53e11d

Merge branch 'master' into Igor_API_Key_validation

67f90eb

Merge branch 'master' into Igor_API_Key_validation

45a2735

Merge branch 'main' into Igor_API_Key_validation

8ab1871

Merge branch 'main' into Igor_API_Key_validation

3a7a753

Merge branch 'main' into Igor_API_Key_validation

e15903e

Merge branch 'main' into Igor_API_Key_validation

b60ad26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Igor api key validation #1783

Igor api key validation #1783

IgorGuz2000 commented Nov 5, 2021 •

edited

Loading

mergify bot commented Nov 5, 2021

elasticmachine commented Nov 5, 2021 •

edited

Loading

Build stats

Test stats 🧪

`Initializing / End-To-End Tests / fleet_amd64_fleet_mode_agent / Un-enrolling with revoke agent deactivates the agent – Fleet Mode Agent`

`Initializing / End-To-End Tests / kubernetes_autodiscover_elastic-agent / [empty] – TEST-x86_64-kubernetes-autodiscover-79e77bf2-2022-01-20-19:34:32.xml`

`Initializing / End-To-End Tests / fleet_arm64_fleet_mode_agent / Deploying the agent with enroll and then run on rpm and deb – Fleet Mode Agent`

`Initializing / End-To-End Tests / fleet_sles15_fleet_mode_agent / Deploying the agent with enroll and then run on rpm and deb – Fleet Mode Agent`

`Initializing / End-To-End Tests / fleet_amd64_fleet_mode_agent / Deploying the agent with enroll and then run on rpm and deb – Fleet Mode Agent`

`Shell Script`

`Archive the artifacts`

Genuine test errors

adam-stokes commented Nov 11, 2021

mdelapenya left a comment

IgorGuz2000 commented Nov 18, 2021

mergify bot commented Nov 30, 2021

mergify bot commented Mar 29, 2022

mergify bot commented Sep 27, 2022

mergify bot commented Apr 3, 2023

mergify bot commented Aug 21, 2023

mergify bot commented Nov 1, 2023

mergify bot commented Dec 14, 2023

mergify bot commented Feb 20, 2024

Igor api key validation #1783

Are you sure you want to change the base?

Igor api key validation #1783

Conversation

IgorGuz2000 commented Nov 5, 2021 • edited Loading

What does this PR do?

Why is it important?

Checklist

Author's Checklist

How to test this PR locally

Related issues

mergify bot commented Nov 5, 2021

elasticmachine commented Nov 5, 2021 • edited Loading

💔 Tests Failed

Build stats

Test stats 🧪

Test errors

Initializing / End-To-End Tests / fleet_amd64_fleet_mode_agent / Un-enrolling with revoke agent deactivates the agent – Fleet Mode Agent

Initializing / End-To-End Tests / kubernetes_autodiscover_elastic-agent / [empty] – TEST-x86_64-kubernetes-autodiscover-79e77bf2-2022-01-20-19:34:32.xml

Initializing / End-To-End Tests / fleet_arm64_fleet_mode_agent / Deploying the agent with enroll and then run on rpm and deb – Fleet Mode Agent

Initializing / End-To-End Tests / fleet_sles15_fleet_mode_agent / Deploying the agent with enroll and then run on rpm and deb – Fleet Mode Agent

Initializing / End-To-End Tests / fleet_amd64_fleet_mode_agent / Deploying the agent with enroll and then run on rpm and deb – Fleet Mode Agent

Steps errors

Shell Script

Archive the artifacts

🐛 Flaky test report

Genuine test errors

🤖 GitHub comments

adam-stokes commented Nov 11, 2021

mdelapenya left a comment

Choose a reason for hiding this comment

IgorGuz2000 commented Nov 18, 2021

mergify bot commented Nov 30, 2021

mergify bot commented Mar 29, 2022

mergify bot commented Sep 27, 2022

mergify bot commented Apr 3, 2023

mergify bot commented Aug 21, 2023

mergify bot commented Nov 1, 2023

mergify bot commented Dec 14, 2023

mergify bot commented Feb 20, 2024

IgorGuz2000 commented Nov 5, 2021 •

edited

Loading

elasticmachine commented Nov 5, 2021 •

edited

Loading

`Initializing / End-To-End Tests / fleet_amd64_fleet_mode_agent / Un-enrolling with revoke agent deactivates the agent – Fleet Mode Agent`

`Initializing / End-To-End Tests / kubernetes_autodiscover_elastic-agent / [empty] – TEST-x86_64-kubernetes-autodiscover-79e77bf2-2022-01-20-19:34:32.xml`

`Initializing / End-To-End Tests / fleet_arm64_fleet_mode_agent / Deploying the agent with enroll and then run on rpm and deb – Fleet Mode Agent`

`Initializing / End-To-End Tests / fleet_sles15_fleet_mode_agent / Deploying the agent with enroll and then run on rpm and deb – Fleet Mode Agent`

`Initializing / End-To-End Tests / fleet_amd64_fleet_mode_agent / Deploying the agent with enroll and then run on rpm and deb – Fleet Mode Agent`

`Shell Script`

`Archive the artifacts`