ecctl: Prefix config parsing error #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change changes the `ecctl.<struct>.Validate()` funcitons multierrors to use `cloud-sdk-go/pkg/multierror.Prefixed` to improve the quality of our errors to always use prefixes. Additionally, changes the behavior when the ecctl.App fails to be initialized and the config file used is empty (unexisting, or failed to read) to throw an error which instructs the user to run "ecctl init". Resolves elastic#223. Signed-off-by: Marc Lopez <marc5.12@outlook.com>
Kushmaro
reviewed
Apr 7, 2020
Signed-off-by: Marc Lopez <marc5.12@outlook.com>
karencfv
approved these changes
Apr 8, 2020
Signed-off-by: Marc Lopez <marc5.12@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change changes the
ecctl.<struct>.Validate()funcitonsmultierrors to use
cloud-sdk-go/pkg/multierror.Prefixedto improve thequality of our errors to always use prefixes.
Additionally, changes the behavior when the ecctl.App fails to be
initialized and the config file used is empty (unexisting, or failed to
read) to throw an error which instructs the user to run "ecctl init".
Related Issues
Resolves #223.
Resolves #220.
How Has This Been Tested?
Types of Changes