cmd: Remove sdkcmdutil.FileOrStdin use #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the `sdkcmdutil.FileOrStdin` does not work well when coupled with Ansible since it thinks the Stdin is always populated even when not. Resolves elastic#318 Signed-off-by: Marc Lopez <marc5.12@outlook.com>
Signed-off-by: Marc Lopez <marc5.12@outlook.com>
4 tasks
karencfv
approved these changes
Jul 8, 2020
Signed-off-by: Marc Lopez <marc5.12@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using the
sdkcmdutil.FileOrStdindoes not work well when coupled withAnsible since it thinks the Stdin is always populated even when not.
Related Issues
Resolves #318
Motivation and Context
Make most
ecctlcommands which have a--fileflag work with Ansible.How Has This Been Tested?
Using
ansible-playbookTypes of Changes