http: Add api.DefaultTransport in http.Client #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the defined sdk `api.DefaultTransport` to the default `http.Client` used by all the API requests. It fixes the issue where responses with a StatusCode different to those specified in the swagger spec result in either an `unknown response` or blank response which makes for very bad UX. After this change, the body of those requests will be shown to the user. Signed-off-by: Marc Lopez <marc5.12@outlook.com>
infraredgirl
approved these changes
Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the defined sdk
api.DefaultTransportto the defaulthttp.Clientused by all the API requests. It fixes the issue where responses with a
StatusCode different to those specified in the swagger spec result in
either an
unknown responseor blank response which makes for very badUX. After this change, the body of those requests will be shown to the
user.
Types of Changes