Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP-5351] Remove Apm from create payload when version >= 8.0.0 #633

Merged
merged 2 commits into from Dec 14, 2023
Merged

[CP-5351] Remove Apm from create payload when version >= 8.0.0 #633

merged 2 commits into from Dec 14, 2023

Conversation

dimuon
Copy link
Contributor

@dimuon dimuon commented Dec 12, 2023 •
edited

Description

Related Issues

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@dimuon dimuon requested a review from a team as a code owner December 12, 2023 17:49
@dimuon
Remove Apm from create payload when version >= 8.0.0.
da2f192 
Add semver as an explicit requirement.
@dimuon dimuon changed the title Remove Apm from create payload when version >= 8.0.0 [CP-5351] Remove Apm from create payload when version >= 8.0.0 Dec 13, 2023
@dimuon dimuon changed the title [CP-5351] Remove Apm from create payload when version >= 8.0.0 CP-5351. Remove Apm from create payload when version >= 8.0.0 Dec 13, 2023
@dimuon dimuon changed the title CP-5351. Remove Apm from create payload when version >= 8.0.0 [CP-5351] Remove Apm from create payload when version >= 8.0.0 Dec 13, 2023
gigerdo
gigerdo approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@gigerdo gigerdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It could be useful to have a test where the input has both APM and integrations-server, and then check only integrations-server is left (As that is the error case we had originally).

@dimuon
Copy link
Contributor Author

dimuon commented Dec 13, 2023

@gigerdo , I've added such a test.

@dimuon dimuon merged commit 03cc42c into elastic:master Dec 14, 2023
3 checks passed
@dimuon dimuon deleted the remove-apm-for-8 branch December 14, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigerdo gigerdo gigerdo approved these changes

@tobio tobio tobio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dimuon @gigerdo @tobio