cmd: Add deployment plan cancel #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the deployment plan cancel command which allows users to cancel pending plans for specific resources. The syntax is as follows: ecctl deployment plan cancel <deployment id> --type <type> --ref-id <id> Signed-off-by: Marc Lopez <marc5.12@outlook.com>
marclop
force-pushed
the
f/add-deployment-plan-cancel
branch
from
4f47cc7
to
8a9c216
Compare
Signed-off-by: Marc Lopez <marc5.12@outlook.com>
infraredgirl
approved these changes
Dec 4, 2019
| merr = multierror.Append(merr, deputil.NewInvalidDeploymentIDError(params.DeploymentID)) | ||
| } | ||
|
|
||
| if params.Type == "" { |
There was a problem hiding this comment.
I'm wondering if it makes any sense to add some checks here about the accepted types. I know we are using this in a few places in the code so we could create a common check. Ignore me if it doesn't worth the time
There was a problem hiding this comment.
We discussed it out of band and agreed that we should't overload this client logic and leave the API to validate the type sent as a queryparam
| } | ||
|
|
||
| // Validate ensures the parameters are usable by the consuming function. | ||
| func (params CancelPlanParams) Validate() error { |
There was a problem hiding this comment.
We are missing test for this method. I think we should explicitly test this function as we already do in other places rather than indirectly test it
ppapapetrou76
approved these changes
Dec 5, 2019
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the deployment plan cancel command which allows users to cancel
pending plans for specific resources.
The syntax is as follows:
ecctl deployment plan cancel <deployment id> --type <type> --ref-id <id>Motivation and Context
Implement more of the Deployment resource APIs.
How Has This Been Tested?
Types of Changes