Skip to content

Commit

Permalink
switch release github action to 'release' trigger
Browse files Browse the repository at this point in the history
  • Loading branch information
@Mpdreamz
Mpdreamz committed Feb 20, 2023
1 parent eb1231b commit b5e88ff
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/release.yml
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
name: release

on:
push:
tags: [ '[0-9]+.[0-9]+.[0-9]+.*' ]
release:
types: [published]
#push:
# tags: [ '[0-9]+.[0-9]+.[0-9]+.*' ]

permissions:
contents: write
Expand Down

3 comments on commit b5e88ff

@Mpdreamz
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @v1v I think this trigger competes with release-main.yml?

The tag push trigger works fine on other .NET repos but they have only one workflow bound to this trigger.

@v1v
Copy link
Member

@v1v v1v commented on b5e88ff Feb 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused, release-main listens for push events on main but none push tag events:

Did it run unexpectedly?

@Mpdreamz
Copy link
Member Author

@Mpdreamz Mpdreamz commented on b5e88ff Feb 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It actually failed to run on the tag creation.

Which is weird because creating tags on github (through creation of releases) works just fine on elastic-ingest-dotnet and several other .NET repositories.

It might have been a fluke.

The tag 8.4.0-alpha1 lives on the main branch so in this case the same commit would trigger both release and release-main.

Please sign in to comment.