Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #87 hostname shouldn't be written in server.IP field #108

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

serdarkalayci
Copy link
Contributor

Writing hostname to the IP field creates logs like the one below:

{"@timestamp":"2020-10-21T14:02:51.7698395+03:00","log.level":"Information","message":"Request starting HTTP/1.1 GET http://10.132.4.163:5111/readiness ","_metadata":{"message_template":"{HostingRequestStartingLog:l}","protocol":"HTTP/1.1","method":"GET","content_type":null,"content_length":null,"scheme":"http","path_base":"","path":"/readiness","query_string":"","hosting_request_starting_log":"Request starting HTTP/1.1 GET http://10.132.4.163:5111/readiness ","event_id":{"id":1},"request_id":"0HM3LHKKTLRML:00000001","request_path":"/readiness","span_id":"|3d1c3928-4b1f17b80024b28b.","trace_id":"3d1c3928-4b1f17b80024b28b","parent_id":"","connection_id":"0HM3LHKKTLRML"},"ecs":{"version":"1.5.0"},"event":{"severity":2,"timezone":"GMT+03:00","created":"2020-10-21T14:02:51.7698395+03:00"},"log":{"logger":"Microsoft.AspNetCore.Hosting.Diagnostics","original":null},"process":{"thread":{"id":25},"pid":1,"name":"dotnet","executable":"dotnet"},"server":{"address":"10.132.4.163:5111","ip":"10.132.4.163:5111"}}

which is not parsable as IP
"failed to parse field [server.ip] of type [ip] in document with id '3TwkS3UBbmzuC991IrD5'. Preview of field's value: '10.132.4.163:5111'","caused_by":{"type":"illegal_argument_exception","reason":"'10.132.4.163:5111' is not an IP string literal."}

@apmmachine
Copy link
Contributor

apmmachine commented Oct 22, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Branch indexing]

  • Start Time: 2020-11-12T00:17:08.303+0000

  • Duration: 10 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 70
Skipped 4
Total 74

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, host can be an IP but we should treat this as incidental.

@Mpdreamz
Copy link
Member

@serdarkalayci mind signing the https://www.elastic.co/contributor-agreement so that I may pull these bits in?

@Mpdreamz Mpdreamz added enhancement New feature or request v1.6.0 labels Nov 16, 2020
@Mpdreamz Mpdreamz merged commit ecb5b58 into elastic:master Nov 16, 2020
@Mpdreamz
Copy link
Member

Thanks for signing @serdarkalayci (and the fix of course 😄)

@russcam russcam added v1.5.3 and removed v1.6.0 labels Jun 1, 2021
@russcam russcam added bug Something isn't working and removed enhancement New feature or request labels Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1.5.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants