Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Exception StackTrace formatting to handle missing StackFrames #117

Merged
merged 3 commits into from
Nov 24, 2020
Merged

Fixed Exception StackTrace formatting to handle missing StackFrames #117

merged 3 commits into from
Nov 24, 2020

Conversation

snakefoot
Copy link
Contributor

Resolves #102

@apmmachine
Copy link
Contributor

apmmachine commented Nov 19, 2020 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Started by user Martijn Laarman, Replayed #1]

  • Start Time: 2020-11-23T12:08:45.580+0000

  • Duration: 11 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 70
Skipped 4
Total 74

Mpdreamz
Mpdreamz approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

src/Elastic.CommonSchema.NLog/README.md
@@ -41,6 +45,54 @@ filesystem target and [Elastic Filebeat](https://www.elastic.co/downloads/beats/
</nlog>
```

## EcsLayout Parameter Options
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this!

@Mpdreamz Mpdreamz added bug Something isn't working v1.6.0 labels Nov 23, 2020
@Mpdreamz Mpdreamz merged commit b7d3fd1 into elastic:master Nov 24, 2020
@russcam russcam added v1.5.3 and removed v1.6.0 labels Jun 1, 2021
russcam pushed a commit that referenced this pull request Jun 1, 2021
@snakefoot @russcam
Fixed Exception StackTrace formatting to handle missing StackFrames (#…
b7b9895 
…117)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees
No one assigned
Labels
bug Something isn't working v1.5.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]CatchErrors in LogConverter - stackframe can be null and is not treated in code
4 participants
@snakefoot @apmmachine @Mpdreamz @russcam