Add support for custom event writer #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
reviewed
May 28, 2024
Mpdreamz
approved these changes
May 28, 2024
There was a problem hiding this comment.
Amazing work @sergiojrdotnet ❤️
Added one small nag I am happy to take on, let me know if you want to address it.
|
run docs-build |
Mpdreamz
requested changes
May 28, 2024
There was a problem hiding this comment.
Some integration test failures sadly:
Elastic.Extensions.Logging.IntegrationTests
- .LoggingToDataStreamTests.SerializesAndDeserializesMessageTemplateAndScope [FAIL]
- .LoggingToIndexTests.SerializesAndDeserializesMessageTemplateAndScope [FAIL]
- .LoggingToIndexTests.LogsEndUpInCluster [FAIL]
- .LoggingToDataStreamTests.MessageTemplateOnLogIsNotTemplatedScope [FAIL]
- .LoggingToDataStreamTests.LogsEndUpInCluster [FAIL]
Failed Elastic.Extensions.Logging.IntegrationTests.LoggingToDataStreamTests.SerializesAndDeserializesMessageTemplateAndScope [1 s]
Error Message:
Expected listener.PublishSuccess to be true because Failed publish over channel: EcsDataStreamChannel`1.
Exported Buffers: 1
Exported Items: 1
Export Responses: 0
Export Retries: 0
Export Exhausts: 0
Export Returned Items to retry: False
Inbound Buffer Read Loop Started: True
Inbound Buffer Publishes: 1
Inbound Buffer Publish Failures: 0
Outbound Buffer Read Loop Started: True
Outbound Buffer Read Loop Exited: False
Outbound Buffer Publishes: 1
Outbound Buffer Publish Failures: 0
Exception: Elastic.Transport.UnexpectedTransportException: JsonTypeInfo metadata for type 'System.String' was not provided by TypeInfoResolver of type 'Elastic.CommonSchema.Serialization.EcsJsonContext'. If using source generation, ensure that all root types passed to the serializer have been annotated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically. The unsupported member type is located on type 'Elastic.CommonSchema.Log'. Path: $.
---> System.NotSupportedException: JsonTypeInfo metadata for type 'System.String' was not provided by TypeInfoResolver of type 'Elastic.CommonSchema.Serialization.EcsJsonContext'. If using source generation, ensure that all root types passed to the serializer have been annotated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically. The unsupported member type is located on type 'Elastic.CommonSchema.Log'. Path: $.
---> System.NotSupportedException: JsonTypeInfo metadata for type 'System.String' was not provided by TypeInfoResolver of type 'Elastic.CommonSchema.Serialization.EcsJsonContext'. If using source generation, ensure that all root types passed to the serializer have been annotated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
|
It looks like there was a problem with my IDE regarding testing, so I didn’t catch the errors. I apologize for the oversight. I’m currently analyzing what happened. |
sergiojrdotnet
changed the title
|
run docs-build |
Mpdreamz
approved these changes
May 29, 2024
|
Again fantastic work @sergiojrdotnet thank you so much for this contribution! |
|
Thanks @Mpdreamz for the speedy review. Next time I’m in Amsterdam, the coffee’s on me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal enables users to supply their own event writers, while also honoring the serialization options they specify.
Furthermore, it introduces the capability to represent enums as strings, thereby enhancing flexibility and usability.
Generated files have been updated by Elastic.CommonSchema.Generator project