Feature/serilog property filter #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Latest commits
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
russcam
reviewed
Jun 25, 2020
src/Elastic.CommonSchema.Serilog/EcsTextFormatterConfiguration.cs
Outdated
Show resolved
Hide resolved
…Set<> to allow user's to control case-sensitivity.
|
jenkins test this please |
|
@ghayes7, I've been out on PTO and looking at this again now |
russcam
suggested changes
Jul 14, 2020
src/Elastic.CommonSchema.Serilog/EcsTextFormatterConfiguration.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Russ Cam <russ.cam@forloop.co.uk>
Co-authored-by: Russ Cam <russ.cam@forloop.co.uk>
…matterConfiguration with existing style.
|
@russcam I think I got everything. Though, github's still saying I missed a suggestion, am I blind? |
|
Thanks for your contribution @ghayes7 |
russcam
added a commit
that referenced
this pull request
Jun 1, 2021
This commit allows filtering of Serilog LogEvent properties from being added to EcsBase.Metadata Co-authored-by: Russ Cam <russ.cam@forloop.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need a way to filter embedded Serilog LogEvent properties from being added to serialized / converted ECS Base.Metadata.
For example if I have embedded properties in my Serilog log event's that I used in the EcsTextFormatterConfiguration.MapCustom to enrich the ECS fields, I won't want it to be added to metadata. There's no other way to filter out a log event property, can't even remove it via EcsTextFormatterConfiguration.MapCustom because it's called after GetMetadata in LogEventConverter.ConvertToEcs. Even if the order was rearranged, still could not remove in MapCustom (i.e. LogEvent.RemovePropertyIfPresent) because the LogEvent is passed by reference so any subsequent renderings of a given logEvent, to different targets will not contain the previously removed property.
Also need a way to set the Serilog Tests LogTestBase classes Formatter property.