Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convenience method for ECS conform config. #12

Merged
merged 7 commits into from Apr 24, 2020

Conversation

simitt
Copy link
Contributor

@simitt simitt commented Apr 23, 2020

Add helper for creating ECS conform config from existing zapcore.Config.

add helper for creating ECS conform config from existing
zapcore.Config
@simitt simitt added the review label Apr 23, 2020
@simitt simitt requested a review from axw April 23, 2020 14:27
json_encoder.go Outdated Show resolved Hide resolved
encoder_config.go Outdated Show resolved Hide resolved
@simitt simitt requested a review from axw April 24, 2020 07:28
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just nits/style comments - feel free to ignore.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
encoder_config_test.go Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@simitt simitt merged commit cdd95a1 into elastic:master Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants