Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: ecszap.WrapCoreOption #22

Merged
merged 3 commits into from Jan 12, 2021
Merged

add: ecszap.WrapCoreOption #22

merged 3 commits into from Jan 12, 2021

Conversation

simitt
Copy link
Contributor

@simitt simitt commented Dec 28, 2020

  • Add ecszap.WrapCoreOption for convenience
  • Update Readme to also show how to transition from existing code by using the zap configuration and the new wrapper function.

closes #15

@simitt simitt mentioned this pull request Dec 28, 2020
Closed
@simitt simitt added the review label Dec 28, 2020
@simitt simitt requested a review from axw December 28, 2020 10:24
@apmmachine
Copy link
Contributor

apmmachine commented Dec 28, 2020 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Branch indexing

  • Start Time: 2021-01-09T11:44:05.331+0000

  • Duration: 4 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 23
Skipped 4
Total 27

axw
axw approved these changes Jan 11, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
simitt and others added 2 commits January 12, 2021 20:46
@simitt simitt merged commit 6dc65b7 into elastic:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axw axw axw approved these changes

Assignees
No one assigned
Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make ecszap.WrapCore available as a zap.Option
3 participants
@simitt @apmmachine @axw