Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "implementing ECS" reference from field descriptions #1364

Closed
ebeahan opened this issue Apr 15, 2021 · 1 comment
Closed

Remove "implementing ECS" reference from field descriptions #1364

ebeahan opened this issue Apr 15, 2021 · 1 comment
Assignees
@ebeahan
Labels
8.0.0 ready Issues we'd like to address in the future.

Comments

@ebeahan
Copy link
Member

ebeahan commented Apr 15, 2021

Several fields include this sentence in the description:

See the documentation section "Implementing ECS".

This section doesn't exist in the ECS docs, so I propose we remove this bit from the descriptions.

Fields:

  • network.application
  • network.protocol
  • network.transport
  • network.type

Relates partially to #745. The potential implementation of a lowercase normalization step/setting (also touched on in #745 (comment)) will be handled elsewhere.
@ebeahan ebeahan added the ready Issues we'd like to address in the future. label Apr 15, 2021
@ebeahan ebeahan mentioned this issue Apr 15, 2021
Closed
@ebeahan ebeahan added the 8.0.0 label Apr 15, 2021
@ebeahan ebeahan self-assigned this Oct 27, 2021
@ebeahan ebeahan mentioned this issue Oct 28, 2021
Merged
@ebeahan
Copy link
Member Author

ebeahan commented Nov 1, 2021

Addressed in #1645

@ebeahan ebeahan closed this as completed Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebeahan ebeahan

Labels
8.0.0 ready Issues we'd like to address in the future.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ebeahan